From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79ADEC433EF for ; Mon, 25 Apr 2022 14:09:37 +0000 (UTC) Received: from localhost ([::1]:44294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nizPE-00072u-Gp for qemu-devel@archiver.kernel.org; Mon, 25 Apr 2022 10:09:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nizO1-00044y-PZ for qemu-devel@nongnu.org; Mon, 25 Apr 2022 10:08:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:34158) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nizNz-0001ve-Ug for qemu-devel@nongnu.org; Mon, 25 Apr 2022 10:08:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650895699; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xno2021meW7LEWiXQuf+nffEFdg6lMv/SmWcXi9TiWw=; b=QjWJHqRTKO8u23Ck7t4oP7rTjPTe/otBFwfhCFsHobnqemG7OxxwL//BGJNXySfPmcTd6X smX77TF9o2d+bbpTlwg2AyvuBlMoBxUWKGyrhBOlxaIyUiPPd8OAFRo+8lcA88DsfjFxsU 63xrA5CeWNXL4nFhmjFGjE3Cfm9Qjao= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-507-bS99B7hLMmKo9ZJHsllMEQ-1; Mon, 25 Apr 2022 10:08:17 -0400 X-MC-Unique: bS99B7hLMmKo9ZJHsllMEQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D2FB21C05AF4; Mon, 25 Apr 2022 14:08:16 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63394200BCD8; Mon, 25 Apr 2022 14:07:01 +0000 (UTC) Date: Mon, 25 Apr 2022 15:06:58 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Martin Kletzander , Peter Maydell , Pavel Dovgalyuk , libvir-list@redhat.com, Christian Schoenebeck , qemu-devel@nongnu.org, Yanan Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Qiuhao Li , =?utf-8?B?SGVydsOp?= Poussineau , Marcel Apfelbaum , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Laurent Vivier , Thomas Huth , Alistair Francis , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, Jan Kiszka , Stefan Hajnoczi , Eduardo Habkost , Darren Kenny , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini Subject: Re: [PATCH 03/18] hw/audio: Simplify hda audio init Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Apr 25, 2022 at 02:35:03PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 25, 2022 at 10:21:46AM +0200, Martin Kletzander wrote: > > No return values are used anywhere, so switch the functions to be void > > and add support for error reporting using errp for use in next patches. > > Making it 'void' makes sense, but I'm not sure we need the Error **errp > addition, given my comment on patch #13. Nevermind, I revised my comment on that patch, so Reviewed-by: Daniel P. Berrangé > > > > > Signed-off-by: Martin Kletzander > > --- > > hw/audio/hda-codec.c | 32 ++++++++++++++++++-------------- > > hw/audio/intel-hda.c | 4 +--- > > hw/audio/intel-hda.h | 2 +- > > 3 files changed, 20 insertions(+), 18 deletions(-) > > With regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|