Re: [PULL 0/6] Kraxel 20220425 patches

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Apr 26, 2022 at 09:15:50AM +0200, Gerd Hoffmann wrote:
> On Mon, Apr 25, 2022 at 10:21:00AM -0700, Richard Henderson wrote:
> > On 4/24/22 23:10, Gerd Hoffmann wrote:
> > > The following changes since commit a74782936dc6e979ce371dabda4b1c05624ea87f:
> > > 
> > >    Merge tag 'pull-migration-20220421a' of https://gitlab.com/dagrh/qemu into staging (2022-04-21 18:48:18 -0700)
> > > 
> > > are available in the Git repository at:
> > > 
> > >    git://git.kraxel.org/qemu tags/kraxel-20220425-pull-request
> > > 
> > > for you to fetch changes up to ef798418a3037434951002d0afc5f3d919e294db:
> > > 
> > >    avocado/vnc: add test_change_listen (2022-04-22 13:43:28 +0200)
> > > 
> > > ----------------------------------------------------------------
> > > vnc: add display-update monitor command.
> > > screendump: add png support.
> > > vmsvga: screen update fix.
> > > 
> > > ----------------------------------------------------------------
> > > 
> > > Carwyn Ellis (1):
> > >    hw/display/vmware_vga: do not discard screen updates
> > > 
> > > Kshitij Suri (2):
> > >    Replacing CONFIG_VNC_PNG with CONFIG_PNG
> > >    Added parameter to take screenshot with screendump as PNG
> > > 
> > > Vladimir Sementsov-Ogievskiy (3):
> > >    ui/vnc: refactor arrays of addresses to SocketAddressList
> > >    qapi/ui: add 'display-update' command for changing listen address
> > >    avocado/vnc: add test_change_listen
> > 
> > 
> > Fails testing with
> > 
> >   ERROR: unknown option --disable-vnc-png
> > 
> > See https://gitlab.com/qemu-project/qemu/-/jobs/2374050341
> 
> Hmm, how do I test that?  My CI run didn't include the centos test case
> for some reason: https://gitlab.com/kraxel/qemu/-/pipelines/522456078

That's a job running on the private runner i expect.

Anyway the fix is simple enough - its just a renamed configure
option that needs changing in two places.

$ git grep disable-vnc-png
scripts/ci/org.centos/stream/8/x86_64/configure:--disable-vnc-png \
scripts/meson-buildoptions.sh:    --disable-vnc-png) printf "%s" -Dvnc_png=disabled ;;

The latter seems to be an auto-generated file that gets checked into
git :-(

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|