From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42988C433FE for ; Tue, 26 Apr 2022 10:56:24 +0000 (UTC) Received: from localhost ([::1]:59372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njIrn-0004O0-DA for qemu-devel@archiver.kernel.org; Tue, 26 Apr 2022 06:56:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njIX4-0000DV-MB for qemu-devel@nongnu.org; Tue, 26 Apr 2022 06:35:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:49439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njIX0-0007oI-V9 for qemu-devel@nongnu.org; Tue, 26 Apr 2022 06:34:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650969293; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KtGuWPPIAuIhHsklidM2yMTGEn7vTMVZjRfQnOlbXVg=; b=KknF1EDDH60TVOD+/2N+UloJu78NBule/u39DGZqJCkWXG2wqD8NGZYr9jH/0QVMtbM91B 8rATth0QTGoCwiLuGZBjdo+5cx0rrwrj15GgpECkFeX85W60a0M6G4sR/z6sJsK7OLBOI5 +I3OzLZ+EqfiD6Hy37yuLLMiLnRgZzs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-9mIwJ_YuNHmK_a_28fK5Hg-1; Tue, 26 Apr 2022 06:34:50 -0400 X-MC-Unique: 9mIwJ_YuNHmK_a_28fK5Hg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3CA53185A7A4; Tue, 26 Apr 2022 10:34:50 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9502AC159B3; Tue, 26 Apr 2022 10:34:48 +0000 (UTC) Date: Tue, 26 Apr 2022 11:34:46 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: zhenwei pi Subject: Re: [PATCH v4 2/8] crypto-akcipher: Introduce akcipher types to qapi Message-ID: References: <20220411104327.197048-1-pizhenwei@bytedance.com> <20220411104327.197048-3-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220411104327.197048-3-pizhenwei@bytedance.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: helei.sig11@bytedance.com, mst@redhat.com, jasowang@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, arei.gonglei@huawei.com, linux-crypto@vger.kernel.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Apr 11, 2022 at 06:43:21PM +0800, zhenwei pi wrote: > From: Lei He > > Introduce akcipher types, also include RSA related types. > > Signed-off-by: Lei He > Signed-off-by: zhenwei pi > --- > qapi/crypto.json | 64 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) snip > +## > +# @QCryptoAkCipherOptions: > +# > +# The options that are available for all asymmetric key algorithms > +# when creating a new QCryptoAkCipher. > +# > +# Since: 7.1 > +## > +{ 'union': 'QCryptoAkCipherOptions', > + 'base': { 'algorithm': 'QCryptoAkCipherAlgorithm' }, > + 'discriminator': 'algorithm', > + 'data': { 'rsa': 'QCryptoAkCipherOptionsRSA' }} I mistakenly suggested 'algorithm' here, but for consistency with other fields, I should have said just 'alg'. With that change Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|