qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Atish Kumar Patra <atishp@rivosinc.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
	Juan Quintela <quintela@redhat.com>,
	Bin Meng <bin.meng@windriver.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH v2 1/5] hw/intc: Move mtimer/mtimecmp to aclint
Date: Wed, 27 Apr 2022 13:38:35 +0100	[thread overview]
Message-ID: <Ymk5SyRKTh49d+9U@work-vm> (raw)
In-Reply-To: <CAHBxVyFKkXGhyvv0RVCmGs81-Ai7vd8Ri66svLzP3D1u+1D4Nw@mail.gmail.com>

* Atish Kumar Patra (atishp@rivosinc.com) wrote:
> On Tue, Apr 26, 2022 at 5:50 PM Richard Henderson
> <richard.henderson@linaro.org> wrote:
> >
> > On 4/26/22 16:08, Atish Patra wrote:
> > > @@ -334,7 +334,6 @@ const VMStateDescription vmstate_riscv_cpu = {
> > >           VMSTATE_UINTTL(env.mscratch, RISCVCPU),
> > >           VMSTATE_UINT64(env.mfromhost, RISCVCPU),
> > >           VMSTATE_UINT64(env.mtohost, RISCVCPU),
> > > -        VMSTATE_UINT64(env.timecmp, RISCVCPU),
> > >
> >
> > Must bump version_id and minimum_version_id.
> >
> 
> Yeah. Fixed that. Thanks.

When you start getting stable machine type versions it'll become harder
and you might have to put dummy entries in to keep compatibility.

Dave

> > r~
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



  reply	other threads:[~2022-04-27 12:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 23:08 [PATCH v2 0/5] Implement Sstc extension Atish Patra
2022-04-26 23:08 ` [PATCH v2 1/5] hw/intc: Move mtimer/mtimecmp to aclint Atish Patra
2022-04-27  0:50   ` Richard Henderson
2022-04-27  2:33     ` Atish Kumar Patra
2022-04-27 12:38       ` Dr. David Alan Gilbert [this message]
2022-04-26 23:08 ` [PATCH v2 2/5] migration: Add 64bit variable array data type Atish Patra
2022-04-27  0:50   ` Richard Henderson
2022-04-27  2:36     ` Atish Kumar Patra
2022-04-26 23:08 ` [PATCH v2 3/5] hw/intc: Support migration of aclint device Atish Patra
2022-04-27  0:51   ` Richard Henderson
2022-04-26 23:08 ` [PATCH v2 4/5] target/riscv: Add stimecmp support Atish Patra
2022-04-27  0:54   ` Richard Henderson
2022-04-26 23:08 ` [PATCH v2 5/5] target/riscv: Add vstimecmp support Atish Patra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ymk5SyRKTh49d+9U@work-vm \
    --to=dgilbert@redhat.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=atishp@rivosinc.com \
    --cc=bin.meng@windriver.com \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).