From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF4DCC433FE for ; Wed, 27 Apr 2022 12:43:31 +0000 (UTC) Received: from localhost ([::1]:36736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njh10-000311-NA for qemu-devel@archiver.kernel.org; Wed, 27 Apr 2022 08:43:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njgwM-0000L4-HH for qemu-devel@nongnu.org; Wed, 27 Apr 2022 08:38:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26670) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njgwL-0005Bk-1h for qemu-devel@nongnu.org; Wed, 27 Apr 2022 08:38:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651063120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QG+qohUvS7YLCeQHAp2tUYRscx38gji7GNbYFZLiXOc=; b=Tt7Jx0YydICz/j/eyWokGcW9PcM6FELHU5PCcXR1Lh4zzUIGcUX6FGT7ihDTjB5HF6io/B EkLjNEPCaSaC50/FVeQzsrpxhwglUhB8o+l6IDrsMj6v0Sh3ancauakePKMuzMLia9n+S5 Gxl5XGIk8gYR0mvvivq4TyNwRTtaE2M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-fvUvUrmcOYWELnTz4efzOw-1; Wed, 27 Apr 2022 08:38:39 -0400 X-MC-Unique: fvUvUrmcOYWELnTz4efzOw-1 Received: by mail-wm1-f72.google.com with SMTP id p32-20020a05600c1da000b00393fbf9ab6eso1826682wms.4 for ; Wed, 27 Apr 2022 05:38:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QG+qohUvS7YLCeQHAp2tUYRscx38gji7GNbYFZLiXOc=; b=2D5x2Y0gjnTBtVK5wicmngtGElHlAQ592soYSqts8xUROe0agnb43D35VrnkxOpwoU DYAUpclp/Ec+QwlO2wEtDO2DZ3Eo/IbdZw+uOIxanCKJd3mRWp/mNaPOlI6Pz0kjo65f ihFpLYNxyTwufjAEeXr5aq9GfF2S8nMzJvJ74FVaWx68w8iwNaqR0N3WJJUNDRP3+tKa BuGuxMCrvFUij9kREr4vtfhbVitp5xHzl/2Dp4nFG2Fhpkod/YGlo2qjgRVpJnwciyHU 2rHMUc5KU3i4F5fjGGYmM3pIFd10o1//6wKh4l7fJOmlLy68rVsg26T3qm3aW2nnSD2I pLZw== X-Gm-Message-State: AOAM5319fJrtp7SGhIpkOxSD1lchf3XOXqHr4W4azeOWemO0Dl0M4Ixm I+SrWAs2xSVC18LFUrYsya5pUGhQei9cM7xh3mkpuyCchpr5gNbPIkrQ5n6rbXQWyoWo1bW6kw4 tpdALlq1u0PwQaOA= X-Received: by 2002:a7b:c10d:0:b0:393:fbff:24a9 with SMTP id w13-20020a7bc10d000000b00393fbff24a9mr5496848wmi.53.1651063117871; Wed, 27 Apr 2022 05:38:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIAo6Q4yPWLj5cLSWAsrcYVaH9x1mGQotcQbUePmyFIEoNbXC2/jRBYv0hPYIq7g1V0aPjuw== X-Received: by 2002:a7b:c10d:0:b0:393:fbff:24a9 with SMTP id w13-20020a7bc10d000000b00393fbff24a9mr5496837wmi.53.1651063117671; Wed, 27 Apr 2022 05:38:37 -0700 (PDT) Received: from work-vm (cpc109025-salf6-2-0-cust480.10-2.cable.virginm.net. [82.30.61.225]) by smtp.gmail.com with ESMTPSA id e1-20020a05600c4e4100b00392910b276esm1498748wmq.9.2022.04.27.05.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 05:38:37 -0700 (PDT) Date: Wed, 27 Apr 2022 13:38:35 +0100 From: "Dr. David Alan Gilbert" To: Atish Kumar Patra Subject: Re: [PATCH v2 1/5] hw/intc: Move mtimer/mtimecmp to aclint Message-ID: References: <20220426230855.336292-1-atishp@rivosinc.com> <20220426230855.336292-2-atishp@rivosinc.com> <00335dce-3ca6-b037-be91-4dc3396d6cd0@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.1 (2022-02-19) Received-SPF: pass client-ip=170.10.133.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Juan Quintela , Bin Meng , Richard Henderson , "qemu-devel@nongnu.org Developers" , Alistair Francis , Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Atish Kumar Patra (atishp@rivosinc.com) wrote: > On Tue, Apr 26, 2022 at 5:50 PM Richard Henderson > wrote: > > > > On 4/26/22 16:08, Atish Patra wrote: > > > @@ -334,7 +334,6 @@ const VMStateDescription vmstate_riscv_cpu = { > > > VMSTATE_UINTTL(env.mscratch, RISCVCPU), > > > VMSTATE_UINT64(env.mfromhost, RISCVCPU), > > > VMSTATE_UINT64(env.mtohost, RISCVCPU), > > > - VMSTATE_UINT64(env.timecmp, RISCVCPU), > > > > > > > Must bump version_id and minimum_version_id. > > > > Yeah. Fixed that. Thanks. When you start getting stable machine type versions it'll become harder and you might have to put dummy entries in to keep compatibility. Dave > > r~ > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK