From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03602C433F5 for ; Fri, 29 Apr 2022 18:22:23 +0000 (UTC) Received: from localhost ([::1]:57704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkVG1-0006Xf-PE for qemu-devel@archiver.kernel.org; Fri, 29 Apr 2022 14:22:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkVF4-0005sy-US for qemu-devel@nongnu.org; Fri, 29 Apr 2022 14:21:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:43149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkVF0-0008PG-Gi for qemu-devel@nongnu.org; Fri, 29 Apr 2022 14:21:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651256476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/stkcvJjykGRYHDCQBNH7PAqqEJypDF4kYoHuS+OVKA=; b=gLGGpaHugbBBzMN+di8QpYyiGltIrc6KzqTnknPkVYZ4EFv8bsqSNFYe7rzPdiSzEg/Yae gY6Tb+UZKSQYztTWbY9yOUGzQh4VhXtlemEWj/1GeJI3dU2F1Ec4TKA2R+5JK7bmjt8acT N2rNcA6jylCx55xy5g7IV/6IReTqWnA= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-aTPLANOrNzCKKSBd6fnyzA-1; Fri, 29 Apr 2022 14:21:14 -0400 X-MC-Unique: aTPLANOrNzCKKSBd6fnyzA-1 Received: by mail-il1-f198.google.com with SMTP id f18-20020a926a12000000b002be48b02bc6so4028487ilc.17 for ; Fri, 29 Apr 2022 11:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/stkcvJjykGRYHDCQBNH7PAqqEJypDF4kYoHuS+OVKA=; b=DdiFlIhdD6HQQsxmwuFJfausx8CF6OpXEqL20LW5rvw6owAoE9LKYO0vQRzOy7yzEY QTveoyj2O0q18K5c3mHt/2/Nn/JD7znMSWHr+weLvTsUl0lceMBUh+3hU0sbGTCtvFB2 H0uuW4pEMMkGTOVpJNWY0GCRl4cn5gNIApOYcZvaObR7JwbBMiwm64nNwNhrZgn+YbZa GcRKyD4HZP9xueDkxwDdHb2G31irprIQ8LbOMpjhiUl0EnAQVlIuBOvDEji/K//Z4LPe QUEPCQ06IOkSYj25UwnLnqmlhrDDDrAIz7uYXi+uj4ql50nWgv3k+HQGif9wEyi3ADOU vcCg== X-Gm-Message-State: AOAM5339qu/zaXIQ+t+4CJshrMi/Zq7haGsHQVav2pgqJepSJTzTn+W0 v4xaOtgug+ulS/qaq074OeuU1/bY5GNWkxb6RwQsPadFicptFEGKpwA+7t1MM3XC7EwpbyBxtgL URec/QMgXq/1zrpw= X-Received: by 2002:a05:6e02:1809:b0:2cc:507a:acfa with SMTP id a9-20020a056e02180900b002cc507aacfamr266312ilv.114.1651256474192; Fri, 29 Apr 2022 11:21:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMQe01BrdjkQTGSc8GhfcNnSFwj4USJ8BqMV1n3p5cbt4caHClRYCCsnFmYOxhkaUoVr9wpg== X-Received: by 2002:a05:6e02:1809:b0:2cc:507a:acfa with SMTP id a9-20020a056e02180900b002cc507aacfamr266282ilv.114.1651256473927; Fri, 29 Apr 2022 11:21:13 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id 70-20020a6b1449000000b00657b4130f57sm1184609iou.25.2022.04.29.11.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 11:21:13 -0700 (PDT) Date: Fri, 29 Apr 2022 14:21:11 -0400 From: Peter Xu To: Joao Martins , Jason Wang Subject: Re: [PATCH RFC 04/10] intel_iommu: Second Stage Access Dirty bit support Message-ID: References: <20220428211351.3897-1-joao.m.martins@oracle.com> <20220428211351.3897-5-joao.m.martins@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "John G . Johnson" , kvm , "Michael S. Tsirkin" , Jason Wang , qemu-devel , Eric Blake , Yi Liu , Juan Quintela , David Hildenbrand , Markus Armbruster , Nicolin Chen , Jason Gunthorpe , Kevin Tian , Richard Henderson , "Dr. David Alan Gilbert" , Eric Auger , Alex Williamson , Paolo Bonzini , Eduardo Habkost , Yishai Hadas , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Thanos Makatos Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Apr 29, 2022 at 10:12:01AM +0100, Joao Martins wrote: > On 4/29/22 03:26, Jason Wang wrote: > > On Fri, Apr 29, 2022 at 5:14 AM Joao Martins wrote: > >> @@ -3693,7 +3759,8 @@ static void vtd_init(IntelIOMMUState *s) > >> > >> /* TODO: read cap/ecap from host to decide which cap to be exposed. */ > >> if (s->scalable_mode) { > >> - s->ecap |= VTD_ECAP_SMTS | VTD_ECAP_SRS | VTD_ECAP_SLTS; > >> + s->ecap |= VTD_ECAP_SMTS | VTD_ECAP_SRS | VTD_ECAP_SLTS | > >> + VTD_ECAP_SLADS; > >> } > > > > We probably need a dedicated command line parameter and make it compat > > for pre 7.1 machines. > > > > Otherwise we may break migration. > > I can gate over an 'x-ssads' option (default disabled). Which reminds me that I probably > should rename to the most recent mnemonic (as SLADS no longer exists in manuals). > > If we all want by default enabled I can add a separate patch to do so. The new option sounds good. Jason, per our previous discussion, shall we not worry about the compatibility issues per machine-type until the whole feature reaches a mostly-complete stage? There seems to have a bunch of sub-features for scalable mode and it's a large project as a whole. I'm worried trying to maintain compatibilities for all the small sub-features could be an unnessary burden to the code base. Thanks, -- Peter Xu