From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80F2FC433F5 for ; Fri, 13 May 2022 16:36:46 +0000 (UTC) Received: from localhost ([::1]:42836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npYHV-0007Nv-Ko for qemu-devel@archiver.kernel.org; Fri, 13 May 2022 12:36:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXpJ-0003oM-4F for qemu-devel@nongnu.org; Fri, 13 May 2022 12:07:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npXpG-0003tw-NJ for qemu-devel@nongnu.org; Fri, 13 May 2022 12:07:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652458053; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sVLFCbuv7GT0PFyQ0e0m8TQj02LHTgqZniygjdgRoKQ=; b=Qgfp7ecs6+e3NsT38PjIvCM5L1Aodmk27rUyEIZXG96cy1Um3Cg6sAjUsr7ZP3NWEPLDJm eQ+aoYM8XJ5abwgAGaJOCsEcoqZUs6WyYQgTWfS4aBbtOy8EeLu+q4gjIKIod49Vrrepwu ceYQRH7cAOiS3tn+9GoBpA5b9ojFdBM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-364-rou7s9R8OAyPpGfGtJukLQ-1; Fri, 13 May 2022 12:07:30 -0400 X-MC-Unique: rou7s9R8OAyPpGfGtJukLQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 35F181010361; Fri, 13 May 2022 16:07:30 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 620594087D66; Fri, 13 May 2022 16:07:28 +0000 (UTC) Date: Fri, 13 May 2022 17:07:26 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Cc: qemu-devel , Qemu-block , Cleber Rosa , Alex =?utf-8?Q?Benn=C3=A9e?= , Hanna Reitz , Thomas Huth , Kevin Wolf , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: Re: [RFC PATCH 0/9] tests: run python tests under the build/tests/venv environment Message-ID: References: <20220513000609.197906-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.1 (2022-02-19) X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, May 13, 2022 at 11:55:18AM -0400, John Snow wrote: > On Fri, May 13, 2022, 6:29 AM Daniel P. Berrangé > wrote: > > > On Fri, May 13, 2022 at 09:35:23AM +0100, Daniel P. Berrangé wrote: > > > On Thu, May 12, 2022 at 08:06:00PM -0400, John Snow wrote: > > > > RFC: This is a very early, crude attempt at switching over to an > > > > external Python package dependency for QMP. This series does not > > > > actually make the switch in and of itself, but instead just switches to > > > > the paradigm of using a venv in general to install the QEMU python > > > > packages instead of using PYTHONPATH to load them from the source tree. > > > > > > > > (By installing the package, we can process dependencies.) > > > > > > > > I'm sending it to the list so I can show you some of what's ugly so far > > > > and my notes on how I might make it less ugly. > > > > > > > > (1) This doesn't trigger venv creation *from* iotests, it merely prints > > > > a friendly error message if "make check-venv" has not been run > > > > first. Not the greatest. > > > > > > So if we run the sequence > > > > > > mkdir build > > > cd build > > > ../configure > > > make > > > ./tests/qemu-iotests/check 001 > > > > > > It won't work anymore, until we 'make check-venv' (or simply > > > 'make check') ? > > > > > > I'm somewhat inclined to say that venv should be created > > > unconditionally by default. ie a plain 'make' should always > > > everything needed to be able to invoke the tests directly. > > > > > > > (2) This isn't acceptable for SRPM builds, because it uses PyPI to > > fetch > > > > packages just-in-time. My thought is to use an environment variable > > like > > > > QEMU_CHECK_NO_INTERNET that changes the behavior of the venv setup > > > > process. We can use "--system-site-packages" as an argument to venv > > > > creation and "--no-index" as an argument to pip installation to achieve > > > > good behavior in SRPM building scenarios. It'd be up to the spec-writer > > > > to opt into that behavior. > > > > > > I think I'd expect --system-site-packages to be the default behaviour. > > > We expect QEMU to be compatible with the packages available in the > > > distros that we're targetting. So if the dev has the python packages > > > installed from their distro, we should be using them preferentially. > > > > > > This is similar to how we bundle slirp/capstone/etc, but will > > > preferentially use the distro version if it is available. > > > > AFAICT from testing it, when '--system-site-packages' is set > > for the venv, then 'pip install' appears to end up being a > > no-op if the package is already present in the host, but > > installs it if missing. > > > > IOW, if we default to --system-site-packages, but still > > also run 'pip install', we should "do the right thing". > > It'll use any distro packages that are available, and > > augment with stuff from pip. In the no-op case, pip will > > still try to consult the pipy servers to fetch version > > info IIUC, so we need to be able to stop that. So I'd > > suggest a --python-env arg taking three values > > > > * "auto" (the default) - add --system-site-packages, but > > also run 'pip install'. Good for developers day-to-day > > > > Sounds like a decent balance... > > ...My only concern is that the system packages might be very old and it's > possible that the qemu packages will be "too new" or have conflicts with > the system deps. > > I'll just have to test this. > > e.g. what if I want to require mypy >= 0.900 for testing, but you have a > system package that requires mypy < 0.700? I would expect us to not require packages that are not present in the distros implied by https://www.qemu.org/docs/master/about/build-platforms.html if that was absolutely a must have, then gracefully skip tests if the system version wasn't new enough. The user could always pass --python-env=pip if they want to force new enough > The python dep compatibility matrix I try to enforce and support for > testing is already feeling overly wide. This might force me to support an > even wider matrix, which I think is the precisely wrong direction for venvs > where we want tighter control as a rule. As above, from a QEMU POV we have clearly defined our targetted platform matrix. Splitting off python packages isn't a reason to change QEMU's platform matrix IMHO. > > * "system" - add --system-site-packages but never run > > 'pip install'. Good for formal package builds. > > > > We still have to install the in-tree qemu ns package, but we can use > --no-index to do it. It'll fail if the deps aren't met. > > * "pip" - don't add --system-site-packages, always run > > 'pip install'. Good for testing compatibility with > > bleeding edge python versions, or if explicit full > > independance from host python install is desired. > > > > as arguments to configure, this spread of options makes sense to me than > paolo's version, but I've still got some doubt on mixing system and venv > packages. > > I am also as of yet not sold on building the venv *from* configure, see my > response to Paolo on that topic. > > I'll keep plugging away for now, but the big picture is still a tad murky > in my head. > > --js With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|