From: Stafford Horne <shorne@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, openrisc@lists.librecores.org
Subject: Re: [PATCH] target/openrisc: implement shutdown and reset helpers
Date: Tue, 3 May 2022 18:14:16 +0900 [thread overview]
Message-ID: <YnDyaEW2QiUXTNx8@antec> (raw)
In-Reply-To: <YnDt0YZK3aG3y8Tl@zx2c4.com>
On Tue, May 03, 2022 at 10:54:41AM +0200, Jason A. Donenfeld wrote:
> On Mon, May 02, 2022 at 04:57:43PM -0700, Richard Henderson wrote:
> > On 5/2/22 15:52, Jason A. Donenfeld wrote:
> > > OpenRISC defines various nop instructions in or1k as meaning shutdown or
> > > reset. Implement these in TCG. This has been tested with Linux and
> > > confirmed to work.
> >
> > No, OpenRISC does not define various nop instructions, etc.
> >
> > OpenRISC defines a Power Management Register to handle doze and suspend; there is no
> > specification for shutdown or reset.
> >
> > See https://openrisc.io/architecture
>
>
> Stafford is in the process of documenting/spec'ing the nop stuff.
Hi Richard,
Yes, we had a mail discussion about this with Peter. This being similar to ARM
semihosting; enabling these special instructions should be behind the semihosting
flag. Something that needs to be done for this patch.
If you have concern about this let me now.
Mail:
- https://www.mail-archive.com/qemu-devel@nongnu.org/msg884560.html
Our other simulators implement this, so the compromise is if we document this
officially and only implement it behind semihosting peter was OK with it.
I haven't started on the documentation yet as I haven't has much time in the
last few days though.
Or1ksim:
- https://github.com/openrisc/or1ksim/blob/79c6f153390127e50259d46a7cc0421aa787d2ed/cpu/or32/insnset.c#L768
sim:
- https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=sim/or1k/or1k.c;h=bfab35461bee1457fe8f42179ac6d27f5ad46b96;hb=HEAD
-Stafford
next prev parent reply other threads:[~2022-05-03 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 22:52 [PATCH] target/openrisc: implement shutdown and reset helpers Jason A. Donenfeld
2022-05-02 23:57 ` Richard Henderson
2022-05-03 8:54 ` Jason A. Donenfeld
2022-05-03 9:14 ` Stafford Horne [this message]
2022-05-03 14:46 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnDyaEW2QiUXTNx8@antec \
--to=shorne@gmail.com \
--cc=Jason@zx2c4.com \
--cc=openrisc@lists.librecores.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).