From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91185C433EF for ; Tue, 3 May 2022 11:00:30 +0000 (UTC) Received: from localhost ([::1]:56782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlqGW-0000Lc-E4 for qemu-devel@archiver.kernel.org; Tue, 03 May 2022 07:00:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlpvI-0000Sz-A6 for qemu-devel@nongnu.org; Tue, 03 May 2022 06:38:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlpvF-0004oq-BZ for qemu-devel@nongnu.org; Tue, 03 May 2022 06:38:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651574304; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/W4dMp5rdBwlm6jl4dB9twmmxxWMLAGIi/ywylhmILE=; b=jOS3eP0Iqex8JEzhwjmn8ljvnmxoDM6NYghp0jtu/2l8mJgX+bwTmW/quZoefUE2a0KCfL GFlYLmahWs9Bke0GaSaTb7rPxPYZ0oZGOg4TMFpB6WmIjtCfJ8hJFUOCLuCNYb80+2Qu/B GgsEtti23+jtV9/evzJTC39hdJ25k5A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-380-setoWfURPjG7NLqESCX5nA-1; Tue, 03 May 2022 06:38:23 -0400 X-MC-Unique: setoWfURPjG7NLqESCX5nA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4EF19185A79C for ; Tue, 3 May 2022 10:38:23 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.197]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C9869E6D; Tue, 3 May 2022 10:38:09 +0000 (UTC) Date: Tue, 3 May 2022 11:38:07 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, Gerd Hoffmann , "Michael S. Tsirkin" Subject: Re: [PATCH v2 22/26] hw: replace qemu_set_nonblock() Message-ID: References: <20220426092715.3931705-1-marcandre.lureau@redhat.com> <20220426092715.3931705-23-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220426092715.3931705-23-marcandre.lureau@redhat.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Apr 26, 2022 at 01:27:11PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Those calls are non-socket fd, or are POSIX-specific. Use the dedicated > GLib API. (qemu_set_nonblock() is for socket-like) > > Signed-off-by: Marc-André Lureau > --- > hw/input/virtio-input-host.c | 5 ++++- > hw/virtio/vhost-vsock.c | 11 +++++++---- > 2 files changed, 11 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|