From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD353C433F5 for ; Wed, 4 May 2022 09:19:32 +0000 (UTC) Received: from localhost ([::1]:60306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmBAR-00087J-IM for qemu-devel@archiver.kernel.org; Wed, 04 May 2022 05:19:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmB3Q-0001SE-7x for qemu-devel@nongnu.org; Wed, 04 May 2022 05:12:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:35104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmB3O-0001K4-B1 for qemu-devel@nongnu.org; Wed, 04 May 2022 05:12:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651655533; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=zILxS6Z3s2oDF+b9gUR/Z/tKxukZ/k7aEh/cpbDAunw=; b=O60C/d+QjaZV4TYfjeDKdBYoN/V8jwdNHH193KXt8JN7ewSMoXugkqxGPVXyN9Eu7JruWu r7yvG/CLEbbl6bwXEbns4zJSReDwym1NO7lpSRsdqeMsC6qI+LltSSzmASV9dr4WfNoGDE 0CTIO+2Pcz6BgBw6OZFiufAZszWn780= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-247-jqsTKCfkPX6rUajuSmRSZA-1; Wed, 04 May 2022 05:12:12 -0400 X-MC-Unique: jqsTKCfkPX6rUajuSmRSZA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EBD8B949041; Wed, 4 May 2022 09:12:11 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 859951559D08; Wed, 4 May 2022 09:12:10 +0000 (UTC) Date: Wed, 4 May 2022 10:12:06 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, John Snow , Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: Re: [RFC PATCH] gitlab-ci: Switch the 'check-patch' & 'check-dco' jobs to use python-container Message-ID: References: <20220503203621.243153-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220503203621.243153-1-thuth@redhat.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 03, 2022 at 10:36:21PM +0200, Thomas Huth wrote: > The 'check-patch' and 'check-dco' jobs only need Python and git for > checking the patches, so it's not really necessary to use a container > here that has all the other build dependencies installed. By installing > "git" in the python container, we can use this light-weight container > for these jobs instead. Our python container is far from light-weight.... $ time podman pull registry.gitlab.com/qemu-project/qemu/qemu/python real 1m52.717s user 1m32.327s sys 0m19.453s vs $ time podman pull python:3.8-alpine real 0m4.509s user 0m3.780s sys 0m1.052s It is quicker to use the alpine python container and then just install 'git' on every job, than it is to use the pre-built qemu python container > > Signed-off-by: Thomas Huth > --- > Mark as RFC since I'm not sure whether we want to have "git" in > the python container or not? > > .gitlab-ci.d/static_checks.yml | 8 ++++---- > tests/docker/dockerfiles/python.docker | 1 + > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml > index 5e955540d3..0e080bd0a0 100644 > --- a/.gitlab-ci.d/static_checks.yml > +++ b/.gitlab-ci.d/static_checks.yml > @@ -1,8 +1,8 @@ > check-patch: > stage: build > - image: $CI_REGISTRY_IMAGE/qemu/centos8:latest > + image: $CI_REGISTRY_IMAGE/qemu/python:latest > needs: > - job: amd64-centos8-container > + job: python-container > script: > - .gitlab-ci.d/check-patch.py > variables: > @@ -15,9 +15,9 @@ check-patch: > > check-dco: > stage: build > - image: $CI_REGISTRY_IMAGE/qemu/centos8:latest > + image: $CI_REGISTRY_IMAGE/qemu/python:latest > needs: > - job: amd64-centos8-container > + job: python-container > script: .gitlab-ci.d/check-dco.py > variables: > GIT_DEPTH: 1000 IOW this is sufficient: image: python:3.8-alpine needs: [] before_script: - apk update - apk add git script: ./gitlab-ci.d/check-dco.py I expect the same would work for check-patch.py container With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|