From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: John Snow <jsnow@redhat.com>, Qemu-block <qemu-block@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
Hanna Reitz <hreitz@redhat.com>,
Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: iotests and python dependencies
Date: Thu, 5 May 2022 14:39:33 +0200 [thread overview]
Message-ID: <YnPFhVqpCIg70MPC@redhat.com> (raw)
In-Reply-To: <a592403d-6a89-6686-1aeb-e04a884657f6@redhat.com>
Am 05.05.2022 um 14:24 hat Paolo Bonzini geschrieben:
> On 5/5/22 12:59, Kevin Wolf wrote:
> > Am 05.05.2022 um 11:28 hat Paolo Bonzini geschrieben:
> > > > Or actually, it could just unconditionally run 'make check-venv' by
> > > > itself, which is probably easier to implement than checking the
> > > > dependencies and more convenient for the user, too.
> > >
> > > One small complication is that on BSD systems the binary is actually
> > > called "gmake", so you'd have to pass the variable somehow
> >
> > I guess we could just export $MAKE as an environment variable?
>
> That would work when invoked by "make", but then that's the case in which
> the venv would be there anyway.
>
> For the other case, it would have to parse config-host.mak and/or
> reintroduce something like tests/qemu-iotests/common.env. All in all it
> seems like an unnecessary complication over just printing a clear and polite
> error message.
Or try 'make' and print the error message only if that fails.
Kevin
next prev parent reply other threads:[~2022-05-05 12:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 19:38 iotests and python dependencies John Snow
2022-05-05 8:09 ` Daniel P. Berrangé
2022-05-05 12:08 ` John Snow
2022-05-05 12:33 ` Daniel P. Berrangé
2022-05-05 13:10 ` John Snow
2022-05-05 13:15 ` Paolo Bonzini
2022-05-05 14:13 ` John Snow
2022-05-05 15:50 ` Paolo Bonzini
2022-05-05 15:57 ` Daniel P. Berrangé
2022-05-08 14:23 ` Paolo Bonzini
2022-05-05 8:51 ` Kevin Wolf
2022-05-05 9:28 ` Paolo Bonzini
2022-05-05 10:59 ` Kevin Wolf
2022-05-05 12:24 ` Paolo Bonzini
2022-05-05 12:39 ` Kevin Wolf [this message]
2022-05-10 17:40 ` John Snow
2022-05-05 11:55 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnPFhVqpCIg70MPC@redhat.com \
--to=kwolf@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=v.sementsov-og@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).