* [PATCH v2] Remove Ubuntu 18.04 conatiner support from the repository
@ 2022-05-16 11:59 Thomas Huth
2022-05-16 14:11 ` Daniel P. Berrangé
2022-05-16 14:14 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2022-05-16 11:59 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal,
Daniel P . Berrangé, Fam Zheng, Heinrich Schuchardt,
Christian Ehrhardt
According to our "Supported build platforms" policy, we now do not support
Ubuntu 18.04 anymore. Remove the related container files and entries from
our CI.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
v2: Omit the VM images from tests/vm/ for now, Philippe wants to rework them
.gitlab-ci.d/containers.yml | 5 -
.../custom-runners/ubuntu-20.04-aarch32.yml | 2 +-
.../custom-runners/ubuntu-20.04-aarch64.yml | 2 +-
scripts/ci/setup/build-environment.yml | 14 +-
tests/docker/dockerfiles/ubuntu1804.docker | 144 ------------------
tests/lcitool/refresh | 7 -
6 files changed, 4 insertions(+), 170 deletions(-)
delete mode 100644 tests/docker/dockerfiles/ubuntu1804.docker
diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
index b9b675fdcb..e9df90bbdd 100644
--- a/.gitlab-ci.d/containers.yml
+++ b/.gitlab-ci.d/containers.yml
@@ -19,11 +19,6 @@ amd64-debian-container:
variables:
NAME: debian-amd64
-amd64-ubuntu1804-container:
- extends: .container_job_template
- variables:
- NAME: ubuntu1804
-
amd64-ubuntu2004-container:
extends: .container_job_template
variables:
diff --git a/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml b/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
index 9c589bc4cf..47856ac53c 100644
--- a/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
+++ b/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch32.yml
@@ -1,6 +1,6 @@
# All ubuntu-20.04 jobs should run successfully in an environment
# setup by the scripts/ci/setup/qemu/build-environment.yml task
-# "Install basic packages to build QEMU on Ubuntu 18.04/20.04"
+# "Install basic packages to build QEMU on Ubuntu 20.04"
ubuntu-20.04-aarch32-all:
needs: []
diff --git a/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml b/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml
index 920e388bd0..951e490db1 100644
--- a/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml
+++ b/.gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml
@@ -1,6 +1,6 @@
# All ubuntu-20.04 jobs should run successfully in an environment
# setup by the scripts/ci/setup/qemu/build-environment.yml task
-# "Install basic packages to build QEMU on Ubuntu 18.04/20.04"
+# "Install basic packages to build QEMU on Ubuntu 20.04"
ubuntu-20.04-aarch64-all-linux-static:
needs: []
diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml
index 9182e0c253..232525b91d 100644
--- a/scripts/ci/setup/build-environment.yml
+++ b/scripts/ci/setup/build-environment.yml
@@ -33,10 +33,9 @@
when:
- ansible_facts['distribution'] == 'Ubuntu'
- - name: Install basic packages to build QEMU on Ubuntu 18.04/20.04
+ - name: Install basic packages to build QEMU on Ubuntu 20.04
package:
name:
- # Originally from tests/docker/dockerfiles/ubuntu1804.docker
- ccache
- gcc
- gettext
@@ -90,7 +89,7 @@
when:
- ansible_facts['distribution'] == 'Ubuntu'
- - name: Install packages to build QEMU on Ubuntu 18.04/20.04 on non-s390x
+ - name: Install packages to build QEMU on Ubuntu 20.04 on non-s390x
package:
name:
- libspice-server-dev
@@ -100,15 +99,6 @@
- ansible_facts['distribution'] == 'Ubuntu'
- ansible_facts['architecture'] != 's390x'
- - name: Install basic packages to build QEMU on Ubuntu 18.04
- package:
- name:
- # Originally from tests/docker/dockerfiles/ubuntu1804.docker
- - clang
- when:
- - ansible_facts['distribution'] == 'Ubuntu'
- - ansible_facts['distribution_version'] == '18.04'
-
- name: Install basic packages to build QEMU on Ubuntu 20.04
package:
name:
diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker
deleted file mode 100644
index b3f2156580..0000000000
--- a/tests/docker/dockerfiles/ubuntu1804.docker
+++ /dev/null
@@ -1,144 +0,0 @@
-# THIS FILE WAS AUTO-GENERATED
-#
-# $ lcitool dockerfile --layers all ubuntu-1804 qemu
-#
-# https://gitlab.com/libvirt/libvirt-ci
-
-FROM docker.io/library/ubuntu:18.04
-
-RUN export DEBIAN_FRONTEND=noninteractive && \
- apt-get update && \
- apt-get install -y eatmydata && \
- eatmydata apt-get dist-upgrade -y && \
- eatmydata apt-get install --no-install-recommends -y \
- bash \
- bc \
- bsdmainutils \
- bzip2 \
- ca-certificates \
- ccache \
- clang \
- dbus \
- debianutils \
- diffutils \
- exuberant-ctags \
- findutils \
- g++ \
- gcc \
- gcovr \
- genisoimage \
- gettext \
- git \
- glusterfs-common \
- hostname \
- libaio-dev \
- libasan5 \
- libasound2-dev \
- libattr1-dev \
- libbrlapi-dev \
- libbz2-dev \
- libc6-dev \
- libcacard-dev \
- libcap-ng-dev \
- libcapstone-dev \
- libcurl4-gnutls-dev \
- libdaxctl-dev \
- libdrm-dev \
- libepoxy-dev \
- libfdt-dev \
- libffi-dev \
- libgbm-dev \
- libgcrypt20-dev \
- libglib2.0-dev \
- libgnutls28-dev \
- libgtk-3-dev \
- libibumad-dev \
- libibverbs-dev \
- libiscsi-dev \
- libjemalloc-dev \
- libjpeg-turbo8-dev \
- liblttng-ust-dev \
- liblzo2-dev \
- libncursesw5-dev \
- libnfs-dev \
- libnuma-dev \
- libpam0g-dev \
- libpcre2-dev \
- libpixman-1-dev \
- libpmem-dev \
- libpng-dev \
- libpulse-dev \
- librbd-dev \
- librdmacm-dev \
- libsasl2-dev \
- libsdl2-dev \
- libsdl2-image-dev \
- libseccomp-dev \
- libselinux1-dev \
- libsnappy-dev \
- libspice-protocol-dev \
- libspice-server-dev \
- libssh-dev \
- libsystemd-dev \
- libtasn1-6-dev \
- libubsan1 \
- libudev-dev \
- libusb-1.0-0-dev \
- libusbredirhost-dev \
- libvdeplug-dev \
- libvirglrenderer-dev \
- libvte-2.91-dev \
- libxen-dev \
- libzstd-dev \
- llvm \
- locales \
- make \
- multipath-tools \
- netcat-openbsd \
- nettle-dev \
- ninja-build \
- openssh-client \
- perl-base \
- pkgconf \
- python3 \
- python3-numpy \
- python3-opencv \
- python3-pillow \
- python3-pip \
- python3-setuptools \
- python3-sphinx \
- python3-sphinx-rtd-theme \
- python3-venv \
- python3-wheel \
- python3-yaml \
- rpm2cpio \
- sed \
- sparse \
- systemtap-sdt-dev \
- tar \
- tesseract-ocr \
- tesseract-ocr-eng \
- texinfo \
- xfslibs-dev \
- zlib1g-dev && \
- eatmydata apt-get autoremove -y && \
- eatmydata apt-get autoclean -y && \
- sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \
- dpkg-reconfigure locales && \
- dpkg-query --showformat '${Package}_${Version}_${Architecture}\n' --show > /packages.txt && \
- mkdir -p /usr/libexec/ccache-wrappers && \
- ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/c++ && \
- ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/cc && \
- ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/clang && \
- ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/g++ && \
- ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/gcc
-
-RUN pip3 install meson==0.56.0
-
-ENV LANG "en_US.UTF-8"
-ENV MAKE "/usr/bin/make"
-ENV NINJA "/usr/bin/ninja"
-ENV PYTHON "/usr/bin/python3"
-ENV CCACHE_WRAPPERSDIR "/usr/libexec/ccache-wrappers"
-# https://bugs.launchpad.net/qemu/+bug/1838763
-ENV QEMU_CONFIGURE_OPTS --disable-libssh
diff --git a/tests/lcitool/refresh b/tests/lcitool/refresh
index 2d198ad281..fb49bbc441 100755
--- a/tests/lcitool/refresh
+++ b/tests/lcitool/refresh
@@ -65,11 +65,6 @@ def generate_cirrus(target, trailer=None):
cmd = lcitool_cmd + ["variables", target, "qemu"]
generate(filename, cmd, trailer)
-ubuntu1804_skipssh = [
- "# https://bugs.launchpad.net/qemu/+bug/1838763\n",
- "ENV QEMU_CONFIGURE_OPTS --disable-libssh\n"
-]
-
ubuntu2004_tsanhack = [
"# Apply patch https://reviews.llvm.org/D75820\n",
"# This is required for TSan in clang-10 to compile with QEMU.\n",
@@ -85,8 +80,6 @@ def debian_cross_build(prefix, targets):
try:
generate_dockerfile("centos8", "centos-stream-8")
generate_dockerfile("fedora", "fedora-35")
- generate_dockerfile("ubuntu1804", "ubuntu-1804",
- trailer="".join(ubuntu1804_skipssh))
generate_dockerfile("ubuntu2004", "ubuntu-2004",
trailer="".join(ubuntu2004_tsanhack))
generate_dockerfile("opensuse-leap", "opensuse-leap-152")
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] Remove Ubuntu 18.04 conatiner support from the repository
2022-05-16 11:59 [PATCH v2] Remove Ubuntu 18.04 conatiner support from the repository Thomas Huth
@ 2022-05-16 14:11 ` Daniel P. Berrangé
2022-05-16 14:14 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2022-05-16 14:11 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal, Fam Zheng,
Heinrich Schuchardt, Christian Ehrhardt
On Mon, May 16, 2022 at 01:59:12PM +0200, Thomas Huth wrote:
> According to our "Supported build platforms" policy, we now do not support
> Ubuntu 18.04 anymore. Remove the related container files and entries from
> our CI.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Omit the VM images from tests/vm/ for now, Philippe wants to rework them
>
> .gitlab-ci.d/containers.yml | 5 -
> .../custom-runners/ubuntu-20.04-aarch32.yml | 2 +-
> .../custom-runners/ubuntu-20.04-aarch64.yml | 2 +-
> scripts/ci/setup/build-environment.yml | 14 +-
> tests/docker/dockerfiles/ubuntu1804.docker | 144 ------------------
> tests/lcitool/refresh | 7 -
> 6 files changed, 4 insertions(+), 170 deletions(-)
> delete mode 100644 tests/docker/dockerfiles/ubuntu1804.docker
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Remove Ubuntu 18.04 conatiner support from the repository
2022-05-16 11:59 [PATCH v2] Remove Ubuntu 18.04 conatiner support from the repository Thomas Huth
2022-05-16 14:11 ` Daniel P. Berrangé
@ 2022-05-16 14:14 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2022-05-16 14:14 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal,
Daniel P . Berrangé, Fam Zheng, Heinrich Schuchardt,
Christian Ehrhardt
On Mon, 16 May 2022 at 14:04, Thomas Huth <thuth@redhat.com> wrote:
>
> According to our "Supported build platforms" policy, we now do not support
> Ubuntu 18.04 anymore. Remove the related container files and entries from
> our CI.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
minor nit: typo in subject: "container"
thanks
-- PMm
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-16 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-16 11:59 [PATCH v2] Remove Ubuntu 18.04 conatiner support from the repository Thomas Huth
2022-05-16 14:11 ` Daniel P. Berrangé
2022-05-16 14:14 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).