From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A786C433EF for ; Thu, 19 May 2022 08:07:50 +0000 (UTC) Received: from localhost ([::1]:56334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrbCG-0005Ml-W4 for qemu-devel@archiver.kernel.org; Thu, 19 May 2022 04:07:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrawq-0007LJ-Rb for qemu-devel@nongnu.org; Thu, 19 May 2022 03:51:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:53939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrawe-0001sK-VQ for qemu-devel@nongnu.org; Thu, 19 May 2022 03:51:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652946700; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BpENLha1vZ1UVposCqYg/cy3lpAcHZblIs2aPgGDdH8=; b=hiTGnaNJJv3JIkmKzBeqTAkRBcUHIhF5IZPlZGtoUHufEgEIPKy7QjX3hi0XpctTHMIJ0j uYQ8oLf4IGILUK6Q3w3ZUjLc0z6zEsvSkE76b0n4Mm5mXkVffkluWMIleNLGU6oq1TDQYI a72ZmiHXqODJQ/+xHXc/dCPh6lMTagU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-279-mPd6eu3MN-2aG9qGXVR2iw-1; Thu, 19 May 2022 03:51:36 -0400 X-MC-Unique: mPd6eu3MN-2aG9qGXVR2iw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F5F3803D45; Thu, 19 May 2022 07:51:36 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 32682C28101; Thu, 19 May 2022 07:51:32 +0000 (UTC) Date: Thu, 19 May 2022 08:51:28 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: Markus Armbruster , Gerd Hoffmann , qemu-devel@nongnu.org, Eric Blake , Paolo Bonzini , libvir-list@redhat.com, Ryan El Kochta Subject: Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser Message-ID: References: <20220518134446.211632-1-thuth@redhat.com> <20220518134446.211632-3-thuth@redhat.com> <87pmkakhdk.fsf@pond.sub.org> <0fa5a892-0053-4172-60f3-d6e5a49a23fd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0fa5a892-0053-4172-60f3-d6e5a49a23fd@redhat.com> User-Agent: Mutt/2.2.1 (2022-02-19) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, May 19, 2022 at 09:27:08AM +0200, Thomas Huth wrote: > On 19/05/2022 09.08, Thomas Huth wrote: > > On 19/05/2022 08.39, Thomas Huth wrote: > > > On 18/05/2022 17.08, Markus Armbruster wrote: > > > > Thomas Huth writes: > > > > > > > > > The "-display sdl" option still uses a hand-crafted parser for its > > > > > parameters since we didn't want to drag an interface we considered > > > > > somewhat flawed into the QAPI schema. Since the flaws are gone now, > > > > > it's time to QAPIfy. > > > > > > > > > > This introduces the new "DisplaySDL" QAPI struct that is used to hold > > > > > the parameters that are unique to the SDL display. The only specific > > > > > parameter is currently "grab-mod" that is used to specify the required > > > > > modifier keys to escape from the mouse grabbing mode. > > > > > > > > > > Signed-off-by: Thomas Huth > > > > > --- > > > > >   qapi/ui.json            | 27 +++++++++++++++- > > > > >   include/sysemu/sysemu.h |  2 -- > > > > >   softmmu/globals.c       |  2 -- > > > > >   softmmu/vl.c            | 70 +---------------------------------------- > > > > >   ui/sdl2.c               | 10 ++++++ > > > > >   5 files changed, 37 insertions(+), 74 deletions(-) > > > > > > > > > > diff --git a/qapi/ui.json b/qapi/ui.json > > > > > index 11a827d10f..a244e26e0f 100644 > > > > > --- a/qapi/ui.json > > > > > +++ b/qapi/ui.json > > > > > @@ -1295,6 +1295,30 @@ > > > > >         '*swap-opt-cmd': 'bool' > > > > >     } } > > > > > +## > > > > > +# @GrabMod: > > > > > +# > > > > > +# Set of modifier keys that need to be hold for shortcut key actions. > > > > > +# > > > > > +# Since: 7.1 > > > > > +## > > > > > +{ 'enum'  : 'GrabMod', > > > > > +  'data'  : [ 'lctrl-lalt', 'lshift-lctrl-lalt', 'rctrl' ] } > > > > > > > > This is fine now.  If we ever generalize to "arbitrary set of modifier > > > > keys", it'll become somewhat awkward.  No objection from me. > > Oh well, I just noticed that we already have a GrabToggleKeys enum in > qapi/common.json ... I wonder whether I should try to use that instead? It > seems to be used in a slightly different context, though, if I get that > right ...? It also doesn't distinguish left & right control/alt/shift keys for some reason. So you would end up having to add more enum entries for SDL, none of which overlap with existing enum entries. Rather a pity, as the consistency would have been nice With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|