From: Anthony PERARD via <qemu-devel@nongnu.org>
To: Bernhard Beschow <shentey@gmail.com>
Cc: <qemu-devel@nongnu.org>, <qemu-trivial@nongnu.org>,
<sstabellini@kernel.org>, <paul@xen.org>,
<xen-devel@lists.xenproject.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
John Snow <jsnow@redhat.com>,
"open list:IDE" <qemu-block@nongnu.org>
Subject: Re: [PATCH v2 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug()
Date: Thu, 19 May 2022 15:37:24 +0100 [thread overview]
Message-ID: <YoZWJFatGiKF1pUI@perard.uk.xensource.com> (raw)
In-Reply-To: <20220513180957.90514-4-shentey@gmail.com>
On Fri, May 13, 2022 at 08:09:57PM +0200, Bernhard Beschow wrote:
> This function was declared in a generic and public header, implemented
> in a device-specific source file but only used in xen_platform. Given its
> 'aux' parameter, this function is more xen-specific than piix-specific.
> Also, the hardcoded magic constants seem to be generic and related to
> PCIIDEState and IDEBus rather than piix.
>
> Therefore, move this function to xen_platform, unexport it, and drop the
> "piix3" in the function name as well.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> Reviewed-by: Paul Durrant <paul@xen.org>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2022-05-19 14:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 18:09 [PATCH v2 0/3] PIIX3-IDE XEN cleanup Bernhard Beschow
2022-05-13 18:09 ` [PATCH v2 1/3] hw/ide/piix: Remove redundant "piix3-ide-xen" device class Bernhard Beschow
2022-05-19 14:29 ` Anthony PERARD via
2022-05-13 18:09 ` [PATCH v2 2/3] hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug() Bernhard Beschow
2022-05-19 14:33 ` Anthony PERARD via
2022-05-13 18:09 ` [PATCH v2 3/3] include/hw/ide: Unexport pci_piix3_xen_ide_unplug() Bernhard Beschow
2022-05-19 14:37 ` Anthony PERARD via [this message]
2022-05-30 13:21 ` Philippe Mathieu-Daudé via
2022-05-28 21:23 ` [PATCH v2 0/3] PIIX3-IDE XEN cleanup Bernhard Beschow
2022-06-02 21:30 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoZWJFatGiKF1pUI@perard.uk.xensource.com \
--to=qemu-devel@nongnu.org \
--cc=anthony.perard@citrix.com \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).