From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCDABC433EF for ; Mon, 30 May 2022 11:28:14 +0000 (UTC) Received: from localhost ([::1]:42372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvdZF-0007fX-Hx for qemu-devel@archiver.kernel.org; Mon, 30 May 2022 07:28:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvdSs-0004m7-Fa for qemu-devel@nongnu.org; Mon, 30 May 2022 07:21:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:54789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvdSp-00007p-Rm for qemu-devel@nongnu.org; Mon, 30 May 2022 07:21:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653909695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zj3ZkiP5ytmwUgaA2lgK7WJSeIsF7uLjKFY0siRpgCs=; b=G83Qit4clTrRStOh6Qp2ZWplVYl41zrOTezVvveQLd6cEyx3KchOLNm0zmCLkC3nj+jbr6 8Sh6ZU5sS3JUCbV8gxjPuvTRgyZ6bi84ARhEmvdD1JNByIpMKPEdmkPqYhfhyD6Zb8VCkf rtkNHhG/lw771c8XF9VViOKbkZkDCb0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-101-bLi1NUEFPguhqbKvVzX9Ng-1; Mon, 30 May 2022 07:21:29 -0400 X-MC-Unique: bLi1NUEFPguhqbKvVzX9Ng-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EBA5680A0AD; Mon, 30 May 2022 11:21:28 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 94E57492C3B; Mon, 30 May 2022 11:21:27 +0000 (UTC) Date: Mon, 30 May 2022 13:21:26 +0200 From: Kevin Wolf To: Stefano Garzarella Cc: qemu-devel@nongnu.org, Peter Lieven , Ilya Dryomov , Hanna Reitz , Tingting Mao , qemu-block@nongnu.org Subject: Re: [PATCH v2] block/rbd: report a better error when namespace does not exist Message-ID: References: <20220517071012.6120-1-sgarzare@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517071012.6120-1-sgarzare@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 17.05.2022 um 09:10 hat Stefano Garzarella geschrieben: > If the namespace does not exist, rbd_create() fails with -ENOENT and > QEMU reports a generic "error rbd create: No such file or directory": > > $ qemu-img create rbd:rbd/namespace/image 1M > Formatting 'rbd:rbd/namespace/image', fmt=raw size=1048576 > qemu-img: rbd:rbd/namespace/image: error rbd create: No such file or directory > > Unfortunately rados_ioctx_set_namespace() does not fail if the namespace > does not exist, so let's use rbd_namespace_exists() in qemu_rbd_connect() > to check if the namespace exists, reporting a more understandable error: > > $ qemu-img create rbd:rbd/namespace/image 1M > Formatting 'rbd:rbd/namespace/image', fmt=raw size=1048576 > qemu-img: rbd:rbd/namespace/image: namespace 'namespace' does not exist > > Reported-by: Tingting Mao > Reviewed-by: Ilya Dryomov > Signed-off-by: Stefano Garzarella Thanks, applied to the block branch. Kevin