From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA753C433EF for ; Mon, 30 May 2022 13:19:09 +0000 (UTC) Received: from localhost ([::1]:41396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nvfIa-00011m-IE for qemu-devel@archiver.kernel.org; Mon, 30 May 2022 09:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvfFA-0006zf-Vb for qemu-devel@nongnu.org; Mon, 30 May 2022 09:15:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nvfF9-0001A5-06 for qemu-devel@nongnu.org; Mon, 30 May 2022 09:15:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653916533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OkfMTM28BxZcyfLjiiWYJfQsHLMyYmSIma/wxw6I30Q=; b=NTIR2dy7vREZimkiZrvvO2m9aFf+ZB5H6WFqHusS1cAjfo2A9uB69FSrDClROweRz6OReg 0FQSr9di6m4S6lq47F2SYF6XSphTUSlwJyx1uxbS1b0COl91sLhwiTpz7mT0FmmOTvXxzB O5SzgZI2a+DAVm9M5qufwzkrzQ0mUlc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-giwyIFMkOr-x49OsgYWkmw-1; Mon, 30 May 2022 09:15:29 -0400 X-MC-Unique: giwyIFMkOr-x49OsgYWkmw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1887D100DE6B; Mon, 30 May 2022 13:15:29 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A05A61410F37; Mon, 30 May 2022 13:15:27 +0000 (UTC) Date: Mon, 30 May 2022 15:15:26 +0200 From: Kevin Wolf To: Fabian Ebner Cc: qemu-devel@nongnu.org, hreitz@redhat.com, qemu-block@nongnu.org, integration@gluster.org, qemu-stable@nongnu.org, eblake@redhat.com, vsementsov@virtuozzo.com, sgarzare@redhat.com Subject: Re: [PATCH v3] block/gluster: correctly set max_pdiscard Message-ID: References: <20220520075922.43972-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520075922.43972-1-f.ebner@proxmox.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 20.05.2022 um 09:59 hat Fabian Ebner geschrieben: > On 64-bit platforms, assigning SIZE_MAX to the int64_t max_pdiscard > results in a negative value, and the following assertion would trigger > down the line (it's not the same max_pdiscard, but computed from the > other one): > qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion > `max_pdiscard >= bs->bl.request_alignment' failed. > > On 32-bit platforms, it's fine to keep using SIZE_MAX. > > The assertion in qemu_gluster_co_pdiscard() is checking that the value > of 'bytes' can safely be passed to glfs_discard_async(), which takes a > size_t for the argument in question, so it is kept as is. And since > max_pdiscard is still <= SIZE_MAX, relying on max_pdiscard is still > fine. > > Fixes: 0c8022876f ("block: use int64_t instead of int in driver discard handlers") > Cc: qemu-stable@nongnu.org > Signed-off-by: Fabian Ebner Thanks, applied to the block branch. Kevin