From: Klaus Jensen <its@irrelevant.dk>
To: Lukasz Maniak <lukasz.maniak@linux.intel.com>
Cc: qemu-devel@nongnu.org, Keith Busch <kbusch@kernel.org>,
qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
lukasz.gieryk@linux.intel.com
Subject: Re: [PATCH v2] hw/nvme: clean up CC register write logic
Date: Fri, 3 Jun 2022 22:24:51 +0200 [thread overview]
Message-ID: <YppuEyXp/iL06z/C@apples> (raw)
In-Reply-To: <YpdpjLHhJDpTn7kP@kzawora-mobl.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On Jun 1 15:28, Lukasz Maniak wrote:
> On Wed, May 25, 2022 at 09:35:24AM +0200, Klaus Jensen wrote:
> >
> > + stl_le_p(&n->bar.intms, 0);
> > + stl_le_p(&n->bar.intmc, 0);
> > + stl_le_p(&n->bar.cc, 0);
>
> Looks fine, though it seems the NVMe spec says the above registers
> should be cleared during each reset for VF as well.
>
Aren't the values of all other registers than CSTS just undefined? (NVMe
v2.0b, Section 8.26.3)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-03 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 7:35 [PATCH v2] hw/nvme: clean up CC register write logic Klaus Jensen
2022-06-01 13:28 ` Lukasz Maniak
2022-06-03 20:24 ` Klaus Jensen [this message]
2022-06-07 11:06 ` Łukasz Gieryk
2022-06-07 11:23 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YppuEyXp/iL06z/C@apples \
--to=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=lukasz.gieryk@linux.intel.com \
--cc=lukasz.maniak@linux.intel.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).