From: Klaus Jensen <its@irrelevant.dk>
To: Wertenbroek Rick <rick.wertenbroek@heig-vd.ch>
Cc: "qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v2] hw/nvme: allow to pass a memory backend object for the CMB
Date: Fri, 3 Jun 2022 22:43:03 +0200 [thread overview]
Message-ID: <YppyVy9PDz1B/Cfn@apples> (raw)
In-Reply-To: <80A639CD-2E9C-4574-9557-FE61DDBE0C57@heig-vd.ch>
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
On Apr 19 07:20, Wertenbroek Rick wrote:
> Adds the optional -cmbdev= option that takes a QEMU memory backend
> -object to be used to for the CMB (Controller Memory Buffer).
> This option takes precedence over cmb_size_mb= if both used.
> (The size will be deduced from the memory backend option).
>
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@heig-vd.ch>
> ---
> hw/nvme/ctrl.c | 65 ++++++++++++++++++++++++++++++++++++++------------
> hw/nvme/nvme.h | 9 +++----
> 2 files changed, 55 insertions(+), 19 deletions(-)
>
This all looks reasonable enought and straight-forward. But I can't seem
to apply the patch for some reason. git is complaining about 'patch
format detection failed.' and trying to apply manually with patch I'm
getting a 'patch: **** malformed patch at line 55: }'.
Can you try to recreate the patch? Or if you can just put it in a git
repo somewhere, then I can cherry-pick it from there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-03 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 7:20 [PATCH v2] hw/nvme: allow to pass a memory backend object for the CMB Wertenbroek Rick
2022-06-03 20:43 ` Klaus Jensen [this message]
2022-06-07 11:40 ` Wertenbroek Rick
2022-06-07 12:01 ` Wertenbroek Rick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YppyVy9PDz1B/Cfn@apples \
--to=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rick.wertenbroek@heig-vd.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).