From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D04B1C43334 for ; Thu, 30 Jun 2022 14:36:44 +0000 (UTC) Received: from localhost ([::1]:57300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6vHf-0003Dk-KS for qemu-devel@archiver.kernel.org; Thu, 30 Jun 2022 10:36:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6vFs-0001Cl-5h for qemu-devel@nongnu.org; Thu, 30 Jun 2022 10:34:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6vFo-0000vL-6d for qemu-devel@nongnu.org; Thu, 30 Jun 2022 10:34:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656599686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pfTjKJd0k6EF8WqDAJDIYuTSM3YPH6l0DmSSHY9GNWw=; b=MzHRcPst2+QflqBvKEeL9n+kroVQLR5aNOcxpAdeXzJpUiewVNXIujWTezdLrg5dfv/jNv uRQY8WU4dCwj7GMI6RphmiNA1dQ9N98GbCv5WK9lq0P4TZ1bGLyvBLJBcBI0jEbkAVKyc0 ZXxPxHEuGqKSNHn3pGZcPh03fP5yOa4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-140-RffpK2KoMvGnTeNU2M8iuQ-1; Thu, 30 Jun 2022 10:34:45 -0400 X-MC-Unique: RffpK2KoMvGnTeNU2M8iuQ-1 Received: by mail-wm1-f71.google.com with SMTP id j35-20020a05600c1c2300b003a167dfa0ecso1577426wms.5 for ; Thu, 30 Jun 2022 07:34:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pfTjKJd0k6EF8WqDAJDIYuTSM3YPH6l0DmSSHY9GNWw=; b=kGYrgJpVjpB9gLCADcsDqyaiZCn+H+6p6Tq9G05o+XYfO578btlzb3f6HKlyf5HXeZ cQ8VBU53MOw50TY19C0lYIojpYxnY684FW/j+aKVoTt5AzLkGSPwJJJygnN3D2PXJrvp q2MACUCADypIthYQYJNmLMskKGzm7OuaEhRBdC/n0Jj5QCcV3Lebz2bwesViFdWkKYtI r2W8TccDZ7atgvCSkQ7jDDamXe23+N8o0O0bVe/m3kVOrSu3TztXbzJdsCR8jECA7gzA AqepTN/FfHN2kUrZGTCwSB7jYJYwCXVMqB0X/o6phOkCXG57Xz8uqeClf32TpDND3Kmu lhiQ== X-Gm-Message-State: AJIora96mXwGzH4hVz0iXNJ4FW9o/fWhzbibPilMj2ATN4UTIvWmPUkr R+n3JOMXzH74a0PXADBnBFPgwTs1HglChYI/sP/bU9HhRBXRrRAZdkFkdiacSPC6qeUyETbypZr MjyUvTaYrToJUmNY= X-Received: by 2002:a05:600c:4ece:b0:3a1:7816:31a9 with SMTP id g14-20020a05600c4ece00b003a1781631a9mr6749481wmq.100.1656599684155; Thu, 30 Jun 2022 07:34:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tqJ0IV0UOfRedg6lIhxVFuPEM18gmX+3sXhq3vk8w43DLHgUu9HO7Zn03CG4J8XOBDA7fZ6w== X-Received: by 2002:a05:600c:4ece:b0:3a1:7816:31a9 with SMTP id g14-20020a05600c4ece00b003a1781631a9mr6749449wmq.100.1656599683899; Thu, 30 Jun 2022 07:34:43 -0700 (PDT) Received: from work-vm (cpc109025-salf6-2-0-cust480.10-2.cable.virginm.net. [82.30.61.225]) by smtp.gmail.com with ESMTPSA id l10-20020a5d560a000000b0021b9270de3csm20677223wrv.10.2022.06.30.07.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 07:34:43 -0700 (PDT) Date: Thu, 30 Jun 2022 15:34:41 +0100 From: "Dr. David Alan Gilbert" To: Juan Quintela Cc: qemu-devel@nongnu.org, Leonardo Bras , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Marcel Apfelbaum , Eduardo Habkost , Yanan Wang Subject: Re: [PATCH 1/5] multifd: Create property multifd-sync-each-iteration Message-ID: References: <20220621140507.1246-1-quintela@redhat.com> <20220621140507.1246-2-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220621140507.1246-2-quintela@redhat.com> User-Agent: Mutt/2.2.6 (2022-06-05) Received-SPF: pass client-ip=170.10.133.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Juan Quintela (quintela@redhat.com) wrote: > We used to synchronize all channels at the end of each RAM section > sent. That is not needed, so preparing to only synchronize once every > full round in latests patches. > > Notice that we initialize the property as true. We will change the > default when we introduce the new mechanism. I don't understand why this is a property - does it break the actual stream format? Dave > Signed-off-by: Juan Quintela > --- > migration/migration.h | 6 ++++++ > hw/core/machine.c | 1 + > migration/migration.c | 10 ++++++++++ > 3 files changed, 17 insertions(+) > > diff --git a/migration/migration.h b/migration/migration.h > index 485d58b95f..70dae24516 100644 > --- a/migration/migration.h > +++ b/migration/migration.h > @@ -332,6 +332,11 @@ struct MigrationState { > * This save hostname when out-going migration starts > */ > char *hostname; > + /* > + * Synchronize channels after each iteration. > + * We used to do that on the past, but it is suboptimal. > + */ > + bool multifd_sync_each_iteration; > }; > > void migrate_set_state(int *state, int old_state, int new_state); > @@ -374,6 +379,7 @@ int migrate_multifd_channels(void); > MultiFDCompression migrate_multifd_compression(void); > int migrate_multifd_zlib_level(void); > int migrate_multifd_zstd_level(void); > +bool migrate_multifd_sync_each_iteration(void); > > #ifdef CONFIG_LINUX > bool migrate_use_zero_copy_send(void); > diff --git a/hw/core/machine.c b/hw/core/machine.c > index a673302cce..c8a60917e0 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -43,6 +43,7 @@ > GlobalProperty hw_compat_7_0[] = { > { "arm-gicv3-common", "force-8-bit-prio", "on" }, > { "nvme-ns", "eui64-default", "on"}, > + { "migration", "multifd-sync-each-iteration", "on"}, > }; > const size_t hw_compat_7_0_len = G_N_ELEMENTS(hw_compat_7_0); > > diff --git a/migration/migration.c b/migration/migration.c > index 31739b2af9..3f79df0b70 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -2540,6 +2540,13 @@ bool migrate_use_multifd(void) > return s->enabled_capabilities[MIGRATION_CAPABILITY_MULTIFD]; > } > > +bool migrate_multifd_sync_each_iteration(void) > +{ > + MigrationState *s = migrate_get_current(); > + > + return s->multifd_sync_each_iteration; > +} > + > bool migrate_pause_before_switchover(void) > { > MigrationState *s; > @@ -4274,6 +4281,9 @@ static Property migration_properties[] = { > DEFINE_PROP_SIZE("announce-step", MigrationState, > parameters.announce_step, > DEFAULT_MIGRATE_ANNOUNCE_STEP), > + /* We will change to false when we introduce the new mechanism */ > + DEFINE_PROP_BOOL("multifd-sync-each-iteration", MigrationState, > + multifd_sync_each_iteration, true), > > /* Migration capabilities */ > DEFINE_PROP_MIG_CAP("x-xbzrle", MIGRATION_CAPABILITY_XBZRLE), > -- > 2.34.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK