Re: [PULL 00/33] migration queue

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Richard Henderson (richard.henderson@linaro.org) wrote:
> On 6/23/22 02:27, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > The following changes since commit 2b049d2c8dc01de750410f8f1a4eac498c04c723:
> > 
> >    Merge tag 'pull-aspeed-20220622' of https://github.com/legoater/qemu into staging (2022-06-22 07:27:06 -0700)
> > 
> > are available in the Git repository at:
> > 
> >    https://gitlab.com/dagrh/qemu.git tags/pull-migration-20220623a
> > 
> > for you to fetch changes up to 5df0eaff8e24223974bf2516e6dc773695603017:
> > 
> >    tests: Add dirty page rate limit test (2022-06-23 10:18:14 +0100)
> > 
> > ----------------------------------------------------------------
> > Migration pull 2022-06-23
> > 
> > This replaces my pull from yesterday, and Juan's from the day before.
> > 
> > Compared to my pull eysterday:
> >    A one character fix in get_buffer patch spotted by Peter Xu
> > 
> > Compared to Juan's pull:
> >    a) Hopefully fixed non-Linux builds
> >      (Local build test on mingw64 works
> >      Note: the zero-copy capability is now
> >      defined on non-Linux systems)
> >    b) Added Hyman's series - it had been
> >      on queue for a while (sorry for the delay)
> > 
> > In this today migration PULL request:
> > - Dainiel Berrangé - qemufileops cleanup
> > - Leonardo Bras  - cleanups for zero copy
> > - Juan Quintela  - RDMA cleanups
> > - Hyman Huang - per-vcpu dirty ring work
> 
> New build failure on all 32-bit hosts:
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/2631167210
> 
> ../softmmu/dirtylimit.c: In function ‘vcpu_dirty_rate_get’:
> /builds/qemu-project/qemu/include/qemu/compiler.h:74:36: error: static
> assertion failed: "not expecting: sizeof(*&rates[cpu_index].dirty_rate) >
> ATOMIC_REG_SIZE"
>    74 | #define QEMU_BUILD_BUG_MSG(x, msg) _Static_assert(!(x), msg)
>       |                                    ^~~~~~~~~~~~~~
> /builds/qemu-project/qemu/include/qemu/compiler.h:76:30: note: in expansion
> of macro ‘QEMU_BUILD_BUG_MSG’
>    76 | #define QEMU_BUILD_BUG_ON(x) QEMU_BUILD_BUG_MSG(x, "not expecting: " #x)
>       |                              ^~~~~~~~~~~~~~~~~~
> /builds/qemu-project/qemu/include/qemu/atomic.h:136:5: note: in expansion of
> macro ‘QEMU_BUILD_BUG_ON’
>   136 |     QEMU_BUILD_BUG_ON(sizeof(*ptr) > ATOMIC_REG_SIZE); \
>       |     ^~~~~~~~~~~~~~~~~
> ../softmmu/dirtylimit.c:120:12: note: in expansion of macro ‘qatomic_read’
>   120 |     return qatomic_read(&rates[cpu_index].dirty_rate);
>       |            ^~~~~~~~~~~~
> 
> Still not fixed on non-linux:
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/2631167373
> 
> ../tests/qtest/migration-test.c:2294:34: error: use of undeclared identifier
> 'DIRTYLIMIT_TOLERANCE_RANGE'
>         if (rate < (quota_rate + DIRTYLIMIT_TOLERANCE_RANGE)) {
>                                  ^
> ../tests/qtest/migration-test.c:2316:34: error: use of undeclared identifier
> 'DIRTYLIMIT_TOLERANCE_RANGE'
>         if (rate > (quota_rate + DIRTYLIMIT_TOLERANCE_RANGE)) {
>                                  ^

Sorry about that; hmm these are both from the extra series I added that
weren't in Juan's first version.  I'll drop it.

Dave

> r~
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK