From: Christoph Hellwig <hch@infradead.org>
To: Niklas Cassel <niklas.cassel@wdc.com>
Cc: kbusch@kernel.org, its@irrelevant.dk, damien.lemoal@wdc.com,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/4] hw/nvme: claim NVMe 2.0 compliance
Date: Mon, 27 Jun 2022 10:59:49 -0700 [thread overview]
Message-ID: <YrnwFTnGdSpKipWA@infradead.org> (raw)
In-Reply-To: <20220627114731.356462-2-niklas.cassel@wdc.com>
On Mon, Jun 27, 2022 at 01:47:28PM +0200, Niklas Cassel via wrote:
> CRMS.CRWMS bit shall be set to 1 on controllers compliant with versions
> later than NVMe 1.4.
>
> The first version later than NVMe 1.4 is NVMe 2.0
>
> Let's claim compliance with NVMe 2.0 such that a follow up patch can
> set the CRMS.CRWMS bit.
>
> This is needed since CC.CRIME is only writable when both CRMS.CRIMS
> and CRMS.CRWMS is set.
You can also always support newer features without claiming
compliance for the new version. I'd suggest to go through the
mandatory changes list first before upgrading the compliance.
(And one day it would be neat if someone tried to run the official
but commercial compliance tests on qemu a well..)
next prev parent reply other threads:[~2022-06-27 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 11:47 [PATCH v2 0/4] hw/nvme: add support for TP4084 Niklas Cassel via
2022-06-27 11:47 ` [PATCH v2 1/4] hw/nvme: claim NVMe 2.0 compliance Niklas Cassel via
2022-06-27 17:59 ` Christoph Hellwig [this message]
2022-06-28 5:58 ` Klaus Jensen
2022-06-27 11:47 ` [PATCH v2 2/4] hw/nvme: store a pointer to the NvmeSubsystem in the NvmeNamespace Niklas Cassel via
2022-06-28 5:57 ` Klaus Jensen
2022-06-27 11:47 ` [PATCH v2 3/4] hw/nvme: add support for ratified TP4084 Niklas Cassel via
2022-06-28 5:57 ` Klaus Jensen
2022-06-27 11:47 ` [PATCH v2 4/4] hw/nvme: add new never_ready parameter to test the DNR bit Niklas Cassel via
2022-06-28 6:07 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrnwFTnGdSpKipWA@infradead.org \
--to=hch@infradead.org \
--cc=damien.lemoal@wdc.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).