qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hongren Zheng <i@zenithal.me>
To: MkfsSion <mkfssion@mkfssion.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, "Canokeys.org" <contact@canokeys.org>
Subject: Re: [PATCH v4] docs/system/devices/canokey: Document limitations on usb-ehci
Date: Tue, 28 Jun 2022 10:21:03 +0800	[thread overview]
Message-ID: <Yrplj2sAB+i9QCv4@Sun> (raw)
In-Reply-To: <20220625142651.19546-1-mkfssion@mkfssion.com>

On Sat, Jun 25, 2022 at 10:26:51PM +0800, MkfsSion wrote:
> Suggested-by: Hongren (Zenithal) Zheng <i@zenithal.me>
> Signed-off-by: YuanYang Meng <mkfssion@mkfssion.com>
> ---
>   v4:
>     Adopt Zenithal's suggestion of repharsing the limitation 
> 
>  docs/system/devices/canokey.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/docs/system/devices/canokey.rst b/docs/system/devices/canokey.rst
> index 169f99b8eb..db33b59e9a 100644
> --- a/docs/system/devices/canokey.rst
> +++ b/docs/system/devices/canokey.rst
> @@ -156,6 +156,11 @@ to it, for example
>  
>     |qemu_system| -device piix3-usb-uhci,id=uhci -device canokey,bus=uhci.0
>  
> +The other limitation is that this device is not compatible with ``usb-ehci``
> +since the device only provides the full-speed mode. However, when a
> +full-speed device attach to a high-speed port, ``usb-ehci`` would complain
> +about speed mismatch.
> +
>  References
>  ==========
>  
> -- 
> 2.36.1
>

Reviewed-by: Hongren (Zenithal) Zheng <i@zenithal.me>

kraxel could you please also queue this up for PULL, thanks!


  reply	other threads:[~2022-06-28  2:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-25 14:21 [PATCH v4 1/2] hw: canokey: Remove HS support as not compliant to the spec MkfsSion
2022-06-25 14:26 ` [PATCH v4] docs/system/devices/canokey: Document limitations on usb-ehci MkfsSion
2022-06-28  2:21   ` Hongren Zheng [this message]
2022-06-28  2:17 ` [PATCH v4 1/2] hw: canokey: Remove HS support as not compliant to the spec Hongren Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yrplj2sAB+i9QCv4@Sun \
    --to=i@zenithal.me \
    --cc=contact@canokeys.org \
    --cc=kraxel@redhat.com \
    --cc=mkfssion@mkfssion.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).