From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Niklas Cassel <niklas.cassel@wdc.com>
Cc: kbusch@kernel.org, its@irrelevant.dk, qemu-block@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/nvme: fix example serial in documentation
Date: Tue, 28 Jun 2022 13:26:25 +0100 [thread overview]
Message-ID: <YrrzcdBRJ2pe2bcb@redhat.com> (raw)
In-Reply-To: <20220627123957.363889-1-niklas.cassel@wdc.com>
On Mon, Jun 27, 2022 at 02:39:57PM +0200, Niklas Cassel via wrote:
> The serial prop on the controller is actually describing the nvme
> subsystem serial, which has to be identical for all controllers within
> the same nvme subsystem.
Given this description...
>
> -device nvme-subsys,id=nvme-subsys-0,nqn=subsys0
...I'm wondering why 'serial' isn't a property of this device..
> - -device nvme,serial=a,subsys=nvme-subsys-0
> - -device nvme,serial=b,subsys=nvme-subsys-0
> + -device nvme,serial=deadbeef,subsys=nvme-subsys-0
> + -device nvme,serial=deadbeef,subsys=nvme-subsys-0
..rather than requiring it to be redundantly set to the same value here ?
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-06-28 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 12:39 [PATCH] hw/nvme: fix example serial in documentation Niklas Cassel via
2022-06-27 17:11 ` Klaus Jensen
2022-06-28 12:26 ` Daniel P. Berrangé [this message]
2022-06-28 12:31 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrrzcdBRJ2pe2bcb@redhat.com \
--to=berrange@redhat.com \
--cc=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).