From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org,
"Daniel P . Berrange" <berrange@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
Manish Mishra <manish.mishra@nutanix.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH v8 01/15] fixup! migration: remove the QEMUFileOps 'get_buffer' callback
Date: Tue, 28 Jun 2022 15:04:48 +0100 [thread overview]
Message-ID: <YrsKgH8B65XrBCFe@work-vm> (raw)
In-Reply-To: <20220622204920.79061-2-peterx@redhat.com>
* Peter Xu (peterx@redhat.com) wrote:
> This fixes a bug with the cleanup patch. Should be squashed into the patch
> in subject.
Yep, that one is already in; thanks.
Dave
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> migration/qemu-file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index 3a380a6072..1e80d496b7 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -375,7 +375,7 @@ static ssize_t qemu_fill_buffer(QEMUFile *f)
> qio_channel_wait(f->ioc, G_IO_IN);
> }
> } else if (len < 0) {
> - len = EIO;
> + len = -EIO;
> }
> } while (len == QIO_CHANNEL_ERR_BLOCK);
>
> --
> 2.32.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2022-06-28 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 20:49 [PATCH v8 00/15] migration: Postcopy Preemption Peter Xu
2022-06-22 20:49 ` [PATCH v8 01/15] fixup! migration: remove the QEMUFileOps 'get_buffer' callback Peter Xu
2022-06-28 14:04 ` Dr. David Alan Gilbert [this message]
2022-06-22 20:49 ` [PATCH v8 02/15] migration: Add postcopy-preempt capability Peter Xu
2022-06-22 20:49 ` [PATCH v8 03/15] migration: Postcopy preemption preparation on channel creation Peter Xu
2022-06-22 20:49 ` [PATCH v8 04/15] migration: Postcopy preemption enablement Peter Xu
2022-06-22 20:49 ` [PATCH v8 05/15] migration: Postcopy recover with preempt enabled Peter Xu
2022-06-22 20:49 ` [PATCH v8 06/15] migration: Create the postcopy preempt channel asynchronously Peter Xu
2022-06-22 20:49 ` [PATCH v8 07/15] migration: Add property x-postcopy-preempt-break-huge Peter Xu
2022-06-22 20:49 ` [PATCH v8 08/15] migration: Add helpers to detect TLS capability Peter Xu
2022-06-22 20:49 ` [PATCH v8 09/15] migration: Export tls-[creds|hostname|authz] params to cmdline too Peter Xu
2022-06-22 20:49 ` [PATCH v8 10/15] migration: Enable TLS for preempt channel Peter Xu
2022-06-22 20:49 ` [PATCH v8 11/15] migration: Respect postcopy request order in preemption mode Peter Xu
2022-06-22 20:49 ` [PATCH v8 12/15] tests: Move MigrateCommon upper Peter Xu
2022-06-22 20:49 ` [PATCH v8 13/15] tests: Add postcopy tls migration test Peter Xu
2022-06-22 20:49 ` [PATCH v8 14/15] tests: Add postcopy tls recovery " Peter Xu
2022-06-22 20:49 ` [PATCH v8 15/15] tests: Add postcopy preempt tests Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrsKgH8B65XrBCFe@work-vm \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=manish.mishra@nutanix.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).