From: Klaus Jensen <its@irrelevant.dk>
To: Jinhao Fan <fanjinhao21s@ict.ac.cn>
Cc: qemu-devel@nongnu.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v4] hw/nvme: Use ioeventfd to handle doorbell updates
Date: Thu, 14 Jul 2022 07:35:15 +0200 [thread overview]
Message-ID: <Ys+rE/S66bwqmXLm@apples> (raw)
In-Reply-To: <Ys1nz68zLPN3Hq8F@apples>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On Jul 12 14:23, Klaus Jensen wrote:
> On Jul 9 11:06, Jinhao Fan wrote:
> > at 10:24 PM, Jinhao Fan <fanjinhao21s@ict.ac.cn> wrote:
> >
> > > @@ -5793,6 +5891,7 @@ static uint16_t nvme_dbbuf_config(NvmeCtrl *n, const NvmeRequest *req)
> > > uint64_t dbs_addr = le64_to_cpu(req->cmd.dptr.prp1);
> > > uint64_t eis_addr = le64_to_cpu(req->cmd.dptr.prp2);
> > > int i;
> > > + int ret;
> > >
> >
> > I just noticed this ret is unused. Could you help remove this line when
> > applying the patch?
>
> Yes, I noticed it and hot-fixed it ;)
Jinhao,
Applied to nvme-next!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-14 5:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 14:24 [PATCH v4] hw/nvme: Use ioeventfd to handle doorbell updates Jinhao Fan
2022-07-05 17:11 ` Klaus Jensen
2022-07-05 18:43 ` Keith Busch
2022-07-06 11:34 ` Jinhao Fan
2022-07-07 5:51 ` Klaus Jensen
2022-07-07 8:50 ` Jinhao Fan
2022-07-06 10:57 ` Jinhao Fan
2022-07-09 3:06 ` Jinhao Fan
2022-07-12 12:23 ` Klaus Jensen
2022-07-14 5:35 ` Klaus Jensen [this message]
2022-07-25 20:55 ` Klaus Jensen
2022-07-26 7:35 ` Jinhao Fan
2022-07-26 7:41 ` Klaus Jensen
2022-07-26 7:55 ` Jinhao Fan
2022-07-26 9:19 ` Klaus Jensen
2022-07-26 10:09 ` Klaus Jensen
2022-07-26 11:24 ` Klaus Jensen
2022-07-26 11:32 ` Klaus Jensen
2022-07-26 12:08 ` Klaus Jensen
2022-07-27 7:06 ` Klaus Jensen
2022-07-27 8:16 ` Jinhao Fan
2022-07-27 8:21 ` Klaus Jensen
2022-07-27 15:09 ` Jinhao Fan
2022-07-26 12:35 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys+rE/S66bwqmXLm@apples \
--to=its@irrelevant.dk \
--cc=fanjinhao21s@ict.ac.cn \
--cc=kbusch@kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).