From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71D53C433EF for ; Tue, 12 Jul 2022 15:47:14 +0000 (UTC) Received: from localhost ([::1]:57384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oBI6T-00051j-Fd for qemu-devel@archiver.kernel.org; Tue, 12 Jul 2022 11:47:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBI42-00028I-CW for qemu-devel@nongnu.org; Tue, 12 Jul 2022 11:44:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37453) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBI40-0007kJ-8h for qemu-devel@nongnu.org; Tue, 12 Jul 2022 11:44:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657640679; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TqgTDr35Vvlz9sGFjhawS7TauJqHXN7uibTrNxkJRSA=; b=i3tkPqtZbEimwwVgiKROoMHD9zNCKExMpliMy367Z+zZQKGzP3UDz6bOEhk2BuZJX2dPRO 08Up8Dg//UD1+WXRYCTc2xs98ocGUvLzpyYXOUMkphEZ1LvgSjGV6jaJ08QmzAgzNgpRaQ KbMmShsSL2AWXVjHgTjPHFcG/lMDMYg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-456-aqRwOPhlN6KEo8UH3ze27A-1; Tue, 12 Jul 2022 11:44:30 -0400 X-MC-Unique: aqRwOPhlN6KEo8UH3ze27A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B8E5D185A7A4; Tue, 12 Jul 2022 15:44:29 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 323E02026D64; Tue, 12 Jul 2022 15:44:24 +0000 (UTC) Date: Tue, 12 Jul 2022 16:44:21 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Jag Raman Cc: Stefan Hajnoczi , qemu-devel , Thomas Huth , Aarushi Mehta , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Elena Ufimtseva , Marcel Apfelbaum , Laurent Vivier , "qemu-block@nongnu.org" , "Dr. David Alan Gilbert" , Richard Henderson , "virtio-fs@redhat.com" , Hanna Reitz , David Hildenbrand , Alex =?utf-8?Q?Benn=C3=A9e?= , Eric Blake , Kevin Wolf , Beraldo Leal , Peter Xu , Eduardo Habkost , Qiuhao Li , Paolo Bonzini , Markus Armbruster , Bandan Das , "Michael S. Tsirkin" , Stefano Garzarella , Alexander Bulekov , Julia Suvorova , Darren Kenny , Wainer dos Santos Moschetta , John Johnson Subject: Re: [PULL 06/18] vfio-user: build library Message-ID: References: <20220615155129.1025811-1-stefanha@redhat.com> <20220615155129.1025811-7-stefanha@redhat.com> <5CF345CD-94BE-452C-A817-4A8AD3CD734A@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5CF345CD-94BE-452C-A817-4A8AD3CD734A@oracle.com> User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 12, 2022 at 03:27:09PM +0000, Jag Raman wrote: > > > On Jul 12, 2022, at 4:39 AM, Daniel P. Berrangé > wrote: > > On Wed, Jun 15, 2022 at 04:51:17PM +0100, Stefan Hajnoczi wrote: > From: Jagannathan Raman > > > add the libvfio-user library as a submodule. build it as a meson > subproject. > > libvfio-user is distributed with BSD 3-Clause license and > json-c with MIT (Expat) license > > Signed-off-by: Elena Ufimtseva > > Signed-off-by: John G Johnson > > Signed-off-by: Jagannathan Raman > > Reviewed-by: Stefan Hajnoczi > > Message-id: c2adec87958b081d1dc8775d4aa05c897912f025.1655151679.git.jag.raman@oracle.com > > [Changed submodule URL to QEMU's libvfio-user mirror on GitLab. The QEMU > project mirrors its dependencies so that it can provide full source code > even in the event that its dependencies become unavailable. Note that > the mirror repo is manually updated, so please contact me to make newer > libvfio-user commits available. If I become a bottleneck we can set up a > cronjob. > > Updated scripts/meson-buildoptions.sh to match the meson_options.txt > change. Failure to do so can result in scripts/meson-buildoptions.sh > being modified by the build system later on and you end up with a dirty > working tree. > --Stefan] > > snip > > diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker > index 4b20925bbf..10618bfa83 100644 > --- a/tests/docker/dockerfiles/centos8.docker > +++ b/tests/docker/dockerfiles/centos8.docker > @@ -51,6 +51,7 @@ RUN dnf update -y && \ > libbpf-devel \ > libcacard-devel \ > libcap-ng-devel \ > + libcmocka-devel \ > libcurl-devel \ > libdrm-devel \ > libepoxy-devel \ > @@ -59,6 +60,7 @@ RUN dnf update -y && \ > libgcrypt-devel \ > libiscsi-devel \ > libjpeg-devel \ > + json-c-devel \ > libnfs-devel \ > libpmem-devel \ > libpng-devel \ > > Per the big warning message at the top of this file, this package listing > is entirely auto-generated so should not be hand editted like this. Its > content is all driven by mappings in the tests/lcitool/libvirt-ci submodule, > which is what should have been updated. It would have then ensured these > new packages were added to all the dockerfiles, and that the changes are > not losted when the dockerfile is re-generated. > > Thanks for pointing this out, Daniel! > > Will update the libvirt-ci project with this, and update QEMU > once that change is pulled into libvirt-ci. Don't worry, I've just got a libvirt-ci update merged: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/293 as I need to fix QEMU CI for FreeBSD already. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|