From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4AFEC433EF for ; Mon, 4 Jul 2022 10:48:16 +0000 (UTC) Received: from localhost ([::1]:51724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8Jcl-0000sj-P6 for qemu-devel@archiver.kernel.org; Mon, 04 Jul 2022 06:48:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8JaT-00082H-CO for qemu-devel@nongnu.org; Mon, 04 Jul 2022 06:45:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:44499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8JaP-0008EW-8B for qemu-devel@nongnu.org; Mon, 04 Jul 2022 06:45:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656931547; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eyo1thwmR4Td1isJ9cIu6PGKySnWgDx/CgrPK4PZVZI=; b=C5RQLdxatGSvfx5zKnWrN7AFkJfXuRQCLSsjeB9bFeBKVHXvc+sTexPtM0Fz76FOF/PV4t KXdt9bbEhAuO4REUUV9N70mTkABRLzoTbU73K58Y96O/2g+wJmX1Yo43N+/5UduDaGyQsO c+CgevyXLenhu1zLana0RlRaGxgnXu4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-pN1FJLlZN5quwsPB5UqtMw-1; Mon, 04 Jul 2022 06:45:44 -0400 X-MC-Unique: pN1FJLlZN5quwsPB5UqtMw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 221D6811E7A; Mon, 4 Jul 2022 10:45:44 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.151]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E87F2026D64; Mon, 4 Jul 2022 10:45:39 +0000 (UTC) Date: Mon, 4 Jul 2022 11:45:35 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: Stefan Hajnoczi , qemu-devel , Stefan Hajnoczi , Michael Roth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?utf-8?Q?C=C3=A9dric?= Le Goater , Richard Henderson , Peter Maydell , Paolo Bonzini , Michael Tokarev , "qemu-ppc@nongnu.org list:PowerPC" , qemu-arm , Brad Smith , Kamil Rytarowski , Reinoud Zandijk , Ryo ONODERA Subject: Re: [PATCH 1/3] scripts/make-release: Do not include the edk2 sources in the tarball anymore Message-ID: References: <20220704064254.18187-1-thuth@redhat.com> <20220704064254.18187-2-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jul 04, 2022 at 11:37:11AM +0200, Thomas Huth wrote: > On 04/07/2022 11.14, Daniel P. Berrangé wrote: > > On Mon, Jul 04, 2022 at 08:26:34AM +0100, Stefan Hajnoczi wrote: > > > On Mon, 4 Jul 2022 at 07:45, Thomas Huth wrote: > ... > > > > +cat > sources.txt < > > > +The edk2 sources can be downloaded from: > > > > + > > > > +https://github.com/tianocore/edk2/archive/${edk2rev}.tar.gz > > > > > > Please use QEMU's edk2 mirror: > > > https://gitlab.com/qemu-project/edk2 > > > > > > QEMU mirrors all dependencies so that even if upstream projects go > > > offline we can still rebuild all of QEMU from source. > > > > Note that the github/lab generated tarballs are not signed, while > > QEMU's release tarballs are gpg signed, so from that POV this would > > be a regression no matter which site we point to. > > Maybe we should point to the edk2 release page instead? I.e.: > > https://github.com/tianocore/edk2/releases > > Anyway, it's IMHO certainly not *our* job to provide signed edk2 sources here. > > > Also it would need more guidance on what to actually do with the > > tarball, as if you merely unpack it into this dir, it won't work > > as it will be one level of dirs nesting too deep for QEMU's > > build scripts to work. > > I could add some wording how to use the edk2-build.sh script with a > downloaded edk2 tarball if that helps ... not sure whether it is really > required, though, we also don't provide instruction for building any other > firmware yet, as far as I know. Well my thought is that currently you can do 'make -C roms efi' from the unpacked release tarball, and with this change, that no longer works. So we ought to explain what to do to get that working again. This doesn't neccessarily means docs. It could just be 'make' prints out an error telling people what to do, or figure it out itself. If we split off the entire of the 'roms' directory into a self-contained firmware-src tarball, the 'roms/Makefile' would still "just work". With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|