From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 062E1C433EF for ; Mon, 4 Jul 2022 15:49:05 +0000 (UTC) Received: from localhost ([::1]:53680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8OJs-0005xC-3D for qemu-devel@archiver.kernel.org; Mon, 04 Jul 2022 11:49:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8OHX-0004cJ-4S for qemu-devel@nongnu.org; Mon, 04 Jul 2022 11:46:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:59282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8OHU-0006QK-3U for qemu-devel@nongnu.org; Mon, 04 Jul 2022 11:46:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656949595; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LSd/yPwyL7CBLt/O22crqS2PsouLakX4HfvTLAX1yYw=; b=WMcHQBId0ju2FGvXf7fWSlHQ+DNJE5FayQA/Rc0fqUw2jduda5gKyWrbSrDfWk606Kqw/A YkB51Hctl1Il/Has2WouNE2cgnBmdlj3WKIi6xqcMXsjdxQs0026rr4Y8jX4xGxLW5cCx+ B2LWxrzWg8P9qzx/1GPJloRAq4W9gVQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-217-BhVv58M8N8icFbF3ikPTVg-1; Mon, 04 Jul 2022 11:46:33 -0400 X-MC-Unique: BhVv58M8N8icFbF3ikPTVg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 77B89811E80; Mon, 4 Jul 2022 15:46:33 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.151]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50625492CA3; Mon, 4 Jul 2022 15:46:32 +0000 (UTC) Date: Mon, 4 Jul 2022 16:46:29 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Warner Losh Cc: QEMU Developers , Paolo Bonzini , Alex =?utf-8?Q?Benn=C3=A9e?= , Thomas Huth , Peter Maydell , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2 6/7] misc: ensure qemu/osdep.h is included in all .c files Message-ID: References: <20220704152303.760983-1-berrange@redhat.com> <20220704152303.760983-7-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jul 04, 2022 at 09:38:46AM -0600, Warner Losh wrote: > On Mon, Jul 4, 2022 at 9:28 AM Daniel P. Berrangé > wrote: > > > A few files relied on qemu/osdep.h being included via a common > > header. Another file didn't need it because it was actually an > > included file, so ought to have been named .c.inc > > > > Signed-off-by: Daniel P. Berrangé > > --- > > bsd-user/arm/signal.c | 2 ++ > > bsd-user/arm/target_arch_cpu.c | 3 +++ > > bsd-user/{elfcore.c => elfcore.c.inc} | 0 > > bsd-user/elfload.c | 2 +- > > bsd-user/freebsd/os-sys.c | 2 ++ > > bsd-user/i386/signal.c | 2 ++ > > bsd-user/qemu.h | 1 - > > bsd-user/x86_64/signal.c | 2 ++ > > crypto/rsakey.c | 1 + > > qga/cutils.c | 2 ++ > > 10 files changed, 15 insertions(+), 2 deletions(-) > > rename bsd-user/{elfcore.c => elfcore.c.inc} (100%) > > > > The change to bsd-user is fine, though will cause many ripples in the > upstream > branch when I merge it. The ripples likely are worth it in the long run, > and knowing > they are coming and helps me prepare the tree for the merge. If you prefer to delay these changes I don't mind. It just means that it would need a 'bsd-user/.*' exclude rule in the next patch to temporarily skip this chck for bsd-user code. > It also reminds me that once I'm done upstreaming, there's likely benefit > from having > a common elf loader / core generator as much of this code is copied from > linux-user > with the qemu style layered on top.... > > Reviewed-by: Warner Losh With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|