Re: [PATCH] block/io_uring: clarify that short reads can happen

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

On Wed, Jul 06, 2022 at 09:03:41AM +0100, Stefan Hajnoczi wrote:
> Jens Axboe has confirmed that short reads are rare but can happen:
> https://lore.kernel.org/io-uring/YsU%2FCGkl9ZXUI+Tj@stefanha-x1.localdomain/T/#m729963dc577d709b709c191922e98ec79d7eef54
> 
> The luring_resubmit_short_read() comment claimed they were only due to a
> specific io_uring bug that was fixed in Linux commit 9d93a3f5a0c
> ("io_uring: punt short reads to async context"), which is wrong.
> Dominique Martinet found that a btrfs bug also causes short reads. There
> may be more kernel code paths that result in short reads.
> 
> Let's consider short reads fair game.
> 
> Cc: Dominique Martinet <dominique.martinet@atmark-techno.com>
> Based-on: <20220630010137.2518851-1-dominique.martinet@atmark-techno.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/io_uring.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]