From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6659C433EF for ; Thu, 7 Jul 2022 08:32:25 +0000 (UTC) Received: from localhost ([::1]:49002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9Mvx-00039Z-0R for qemu-devel@archiver.kernel.org; Thu, 07 Jul 2022 04:32:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9MiU-0004Lc-UG for qemu-devel@nongnu.org; Thu, 07 Jul 2022 04:18:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:44381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9MiO-0005q3-3N for qemu-devel@nongnu.org; Thu, 07 Jul 2022 04:18:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657181903; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/WLp4C2APFLe2HdTuli8HBiKMXT78OaB1EtrrNVzqkM=; b=TAMHDpG2SrW33k6HzLD5c86ODt7c2KQS5IvlM/Se6QH5z8KWqq64+eh3HD70UIO9uHS/7y J2e3qMReAbWMKIl1IGXV3eeopnXu4NTCvqpCu6pcdkt06tj6B40ZeBTSkMCkWWFtVBJF/2 SiPf77eOqqKakObwXHtbBCVzCKNUEPI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-63-1BNpnVxNNymAZhprE7GsIw-1; Thu, 07 Jul 2022 04:18:20 -0400 X-MC-Unique: 1BNpnVxNNymAZhprE7GsIw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92B3929AB408; Thu, 7 Jul 2022 08:18:19 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE33240315A; Thu, 7 Jul 2022 08:18:17 +0000 (UTC) Date: Thu, 7 Jul 2022 09:18:15 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Hanna Reitz , Wainer dos Santos Moschetta , Beraldo Leal , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Michael Roth , Alex =?utf-8?Q?Benn=C3=A9e?= , Kevin Wolf , Thomas Huth Subject: Re: [PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images Message-ID: References: <20220707040310.4163682-1-jsnow@redhat.com> <20220707040310.4163682-3-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220707040310.4163682-3-jsnow@redhat.com> User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 07, 2022 at 12:02:59AM -0400, John Snow wrote: > If the initial setup fails, you've permanently altered the state of the > downloaded image in an unknowable way. Use 'cp' like our other test > setup scripts do. > > Signed-off-by: John Snow > Reviewed-by: Thomas Huth > --- > tests/vm/centos | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|