From: "Daniel P. Berrangé" <berrange@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
"Hanna Reitz" <hreitz@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Michael Roth" <michael.roth@amd.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH v3 08/13] tests/vm: add 1GB extra memory per core
Date: Thu, 7 Jul 2022 09:27:14 +0100 [thread overview]
Message-ID: <YsaY4rIfe2+yMIfB@redhat.com> (raw)
In-Reply-To: <20220707040310.4163682-9-jsnow@redhat.com>
On Thu, Jul 07, 2022 at 12:03:05AM -0400, John Snow wrote:
> If you try to run a 16 or 32 threaded test, you're going to run out of
> memory very quickly with qom-test and a few others. Bump the memory
> limit to try to scale with larger-core machines.
>
> Granted, this means that a 16 core processor is going to ask for 16GB,
> but you *probably* meet that requirement if you have such a machine.
>
> 512MB per core didn't seem to be enough to avoid ENOMEM and SIGABRTs in
> the test cases in practice on a six core machine; so I bumped it up to
> 1GB which seemed to help.
RHEL recommends 1.5 GB per virtual CPU, so yeah, allowing only 512 MB
was unreasonably small by typical standards.
>
> Add this magic in early to the configuration process so that the
> config file, if provided, can still override it.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/vm/basevm.py | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-07-07 8:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 4:02 [PATCH v3 00/13] Improve reliability of VM tests John Snow
2022-07-07 4:02 ` [PATCH v3 01/13] qga: treat get-guest-fsinfo as "best effort" John Snow
2022-07-07 8:17 ` Daniel P. Berrangé
2022-07-07 8:40 ` Marc-André Lureau
2022-07-07 15:23 ` John Snow
2022-07-07 4:02 ` [PATCH v3 02/13] tests/vm: use 'cp' instead of 'ln' for temporary vm images John Snow
2022-07-07 8:18 ` Daniel P. Berrangé
2022-07-07 4:03 ` [PATCH v3 03/13] tests/vm: switch CentOS 8 to CentOS 8 Stream John Snow
2022-07-07 8:18 ` Daniel P. Berrangé
2022-07-07 4:03 ` [PATCH v3 04/13] tests/vm: switch centos.aarch64 " John Snow
2022-07-07 8:22 ` Daniel P. Berrangé
2022-07-07 4:03 ` [PATCH v3 05/13] tests/vm: update sha256sum for ubuntu.aarch64 John Snow
2022-07-07 8:23 ` Daniel P. Berrangé
2022-07-07 11:03 ` Richard Henderson
2022-07-07 4:03 ` [PATCH v3 06/13] tests/vm: remove ubuntu.i386 VM test John Snow
2022-07-07 8:23 ` Daniel P. Berrangé
2022-07-07 4:03 ` [PATCH v3 07/13] tests/vm: remove duplicate 'centos' " John Snow
2022-07-07 8:24 ` Daniel P. Berrangé
2022-07-07 4:03 ` [PATCH v3 08/13] tests/vm: add 1GB extra memory per core John Snow
2022-07-07 8:27 ` Daniel P. Berrangé [this message]
2022-07-07 4:03 ` [PATCH v3 09/13] tests/vm: upgrade Ubuntu 18.04 VM to 20.04 John Snow
2022-07-07 8:31 ` Daniel P. Berrangé
2022-07-07 11:05 ` Richard Henderson
2022-07-07 15:40 ` John Snow
2022-07-07 4:03 ` [PATCH v3 10/13] tests/vm: Remove docker cross-compile test from CentOS VM John Snow
2022-07-07 8:32 ` Daniel P. Berrangé
2022-07-07 15:48 ` John Snow
2022-07-07 15:52 ` Daniel P. Berrangé
2022-07-07 4:03 ` [PATCH v3 11/13] tests/qemu-iotests: hotfix for 307, 223 output John Snow
2022-07-07 4:03 ` [PATCH v3 12/13] tests/qemu-iotests: skip 108 when FUSE is not loaded John Snow
2022-07-07 4:03 ` [PATCH v3 13/13] iotests: fix copy-before-write for macOS and FreeBSD John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsaY4rIfe2+yMIfB@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=f4bug@amsat.org \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).