From: Roman Kagan <rvkagan@yandex-team.ru>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
yc-core@yandex-team.ru,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>
Subject: Re: [PATCH v2] hw/pci/pci_bridge: ensure PCIe slots have only one slot
Date: Wed, 20 Jul 2022 13:18:58 +0300 [thread overview]
Message-ID: <YtfWkj/mPpWN7y/w@rvkaganb> (raw)
In-Reply-To: <6dc76218-2281-4319-165b-c42086ee7157@redhat.com>
On Tue, Jul 19, 2022 at 12:42:47PM +0200, Thomas Huth wrote:
> On 19/07/2022 10.01, Roman Kagan wrote:
> > +#include "qemu/osdep.h"
> > +#include "libqtest-single.h"
>
> Do you really need libqtest-single.h here? libqtest.h should be enough,
> shouldn't it?
Indeed, will replace with libqtest.h
> > +
> > + qtest_end();
>
> Please drop the qtest_end() - you're already using qtest_quit in the
> individual tests.
ok
Thanks,
Roman.
prev parent reply other threads:[~2022-07-20 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 8:01 [PATCH v2] hw/pci/pci_bridge: ensure PCIe slots have only one slot Roman Kagan
2022-07-19 10:42 ` Thomas Huth
2022-07-20 10:18 ` Roman Kagan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtfWkj/mPpWN7y/w@rvkaganb \
--to=rvkagan@yandex-team.ru \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).