From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2168AC433EF for ; Wed, 20 Jul 2022 14:34:15 +0000 (UTC) Received: from localhost ([::1]:55772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEAmE-0002HK-2v for qemu-devel@archiver.kernel.org; Wed, 20 Jul 2022 10:34:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEAkZ-0001Ck-76 for qemu-devel@nongnu.org; Wed, 20 Jul 2022 10:32:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:28568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEAkV-0004iN-NR for qemu-devel@nongnu.org; Wed, 20 Jul 2022 10:32:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658327545; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bo9T6TqX50t4a4TATCkgp3FTY8am8JMrpn0TipzwZy0=; b=dvHjuY7uHXnDLeWCsjrCR6+cwNeRNltbNbfTDDtBXMeMio8eIVvhgiiuCF7Dpw4fSjKcVa FmXjiWp4rngjb6aOLYyL5REv5gEJeZep/YRwI+DftCgJGyPIQMd7niXqY4ACMEBj00bXlX ki6aIyGEdzqVDAY4PEw3PlQ8I6HKjGc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-359-pGahKTrsP2eKDLOdsxXfRw-1; Wed, 20 Jul 2022 10:32:24 -0400 X-MC-Unique: pGahKTrsP2eKDLOdsxXfRw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A5301C14486 for ; Wed, 20 Jul 2022 14:32:24 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC8EA2166B26; Wed, 20 Jul 2022 14:32:22 +0000 (UTC) Date: Wed, 20 Jul 2022 15:32:20 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: Peter Xu , qemu-devel@nongnu.org, Leonardo Bras Soares Passos , "Dr . David Alan Gilbert" , Juan Quintela Subject: Re: [PATCH] tests: migration-test: Allow test to run without uffd Message-ID: References: <20220707184600.24164-1-peterx@redhat.com> <4ebe2d62-b627-3d2b-3c3e-73701fbf7be5@redhat.com> <9240083d-ef58-466a-14c1-1c858f67e1d4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9240083d-ef58-466a-14c1-1c858f67e1d4@redhat.com> User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jul 20, 2022 at 04:11:43PM +0200, Thomas Huth wrote: > On 19/07/2022 12.37, Daniel P. Berrangé wrote: > > On Tue, Jul 19, 2022 at 12:28:24PM +0200, Thomas Huth wrote: > > > On 18/07/2022 21.14, Peter Xu wrote: > > > > Hi, Thomas, > > > > > > > > On Mon, Jul 18, 2022 at 08:23:26PM +0200, Thomas Huth wrote: > > > > > On 07/07/2022 20.46, Peter Xu wrote: > > > > > > We used to stop running all tests if uffd is not detected. However > > > > > > logically that's only needed for postcopy not the rest of tests. > > > > > > > > > > > > Keep running the rest when still possible. > > > > > > > > > > > > Signed-off-by: Peter Xu > > > > > > --- > > > > > > tests/qtest/migration-test.c | 11 +++++------ > > > > > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > > > > > > > Did you test your patch in the gitlab-CI? I just added it to my testing-next > > > > > branch and the the test is failing reproducibly on macOS here: > > > > > > > > > > https://gitlab.com/thuth/qemu/-/jobs/2736260861#L6275 > > > > > https://gitlab.com/thuth/qemu/-/jobs/2736623914#L6275 > > > > > > > > > > (without your patch the whole test is skipped instead) > > > > > > > > Thanks for reporting this. > > > > > > > > Is it easy to figure out which test was failing on your side? I cannot > > > > easily reproduce this here on a MacOS with M1. > > > > > > I've modified the yml file to only run the migration test in verbose mode > > > and got this: > > > > > > ... > > > ok 5 /x86_64/migration/validate_uuid_src_not_set > > > # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-58011.sock > > > -qtest-log /dev/null -chardev socket,path=/tmp/qtest-58011.qmp,id=char0 -mon > > > chardev=char0,mode=control -display none -accel kvm -accel tcg -name > > > source,debug-threads=on -m 150M -serial > > > file:/tmp/migration-test-ef2fMr/src_serial -drive > > > file=/tmp/migration-test-ef2fMr/bootsect,format=raw -uuid > > > 11111111-1111-1111-1111-111111111111 2>/dev/null -accel qtest > > > # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-58011.sock > > > -qtest-log /dev/null -chardev socket,path=/tmp/qtest-58011.qmp,id=char0 -mon > > > chardev=char0,mode=control -display none -accel kvm -accel tcg -name > > > target,debug-threads=on -m 150M -serial > > > file:/tmp/migration-test-ef2fMr/dest_serial -incoming > > > unix:/tmp/migration-test-ef2fMr/migsocket -drive > > > file=/tmp/migration-test-ef2fMr/bootsect,format=raw 2>/dev/null -accel > > > qtest > > > ok 6 /x86_64/migration/validate_uuid_dst_not_set > > > # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-58011.sock > > > -qtest-log /dev/null -chardev socket,path=/tmp/qtest-58011.qmp,id=char0 -mon > > > chardev=char0,mode=control -display none -accel kvm -accel tcg -name > > > source,debug-threads=on -m 150M -serial > > > file:/tmp/migration-test-ef2fMr/src_serial -drive > > > file=/tmp/migration-test-ef2fMr/bootsect,format=raw -accel qtest > > > # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-58011.sock > > > -qtest-log /dev/null -chardev socket,path=/tmp/qtest-58011.qmp,id=char0 -mon > > > chardev=char0,mode=control -display none -accel kvm -accel tcg -name > > > target,debug-threads=on -m 150M -serial > > > file:/tmp/migration-test-ef2fMr/dest_serial -incoming > > > unix:/tmp/migration-test-ef2fMr/migsocket -drive > > > file=/tmp/migration-test-ef2fMr/bootsect,format=raw -accel qtest > > > ** > > > ERROR:../tests/qtest/migration-helpers.c:181:wait_for_migration_status: > > > assertion failed: (g_test_timer_elapsed() < MIGRATION_STATUS_WAIT_TIMEOUT) > > > Bail out! > > > ERROR:../tests/qtest/migration-helpers.c:181:wait_for_migration_status: > > > assertion failed: (g_test_timer_elapsed() < MIGRATION_STATUS_WAIT_TIMEOUT) > > > > This is the safety net we put it to catch case where the test has > > got stuck. It is set at 2 minutes. > > > > There's a chance that is too short, so one first step might be to > > increase to 10 minutes and see if the tests pass. If it still fails, > > then its likely a genuine bug > > I tried to increase it to 5 minutes first, but that did not help. In a > second try, I increased it to 10 minutes, and then the test was passing, > indeed: > > https://cirrus-ci.com/task/5819072351830016?logs=build#L7208 > > Could it maybe be accelerated, e.g. by tweaking the downtime limit again? Oh when I tweaked convergance tunables i missed the auto-converge case as its code looks a bit different. Possibly change test_migrate_auto_converge /* Now, when we tested that throttling works, let it converge */ migrate_set_parameter_int(from, "downtime-limit", downtime_limit); migrate_set_parameter_int(from, "max-bandwidth", max_bandwidth); to migrate_ensure_converge(from); With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|