From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Zhao, Zhou" <zhou.zhao@intel.com>
Cc: "Xu, Ling1" <ling1.xu@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"quintela@redhat.com" <quintela@redhat.com>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"Jin, Jun I" <jun.i.jin@intel.com>
Subject: Re: [PATCH 1/1] Add AVX512 support for xbzrle_encode_buffer function
Date: Thu, 21 Jul 2022 17:41:48 +0100 [thread overview]
Message-ID: <YtmBzCuMnY2kHr4f@redhat.com> (raw)
In-Reply-To: <DM6PR11MB28126DAC62A921E5551C1400F5919@DM6PR11MB2812.namprd11.prod.outlook.com>
On Thu, Jul 21, 2022 at 04:02:49PM +0000, Zhao, Zhou wrote:
> Hi dainel:
> Cause our code depend on intel intrinsics lib implement. And
> this lib depend on macro like " AVX512BW ". This macro need
> compile time check to enable some machine options . if you only
> use that utility to do runtime check ,you will met compile issue.
> And also if we want to save cpu time , we'd better check it in
> compile time.
Can you give more info about this library ? The patch isn't
linking to any new library so it was not immediately obvious
that this patch even introduced a dependancy on an external
library. Preferrably the library would be using 'pkg-config'
so we can check for it in a single line of meson.build code
instead of writing 100's of lines of configure compile tests.
Generally if the library is available in Linux dijstros, then
we'll want the CI to test that too, which will mean updating
the dockerfiles.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-07-21 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 10:31 [PATCH 0/1] This patch provides AVX512 support for xbzrle_encode_buffer function ling xu
2022-07-21 10:31 ` [PATCH 1/1] Add " ling xu
2022-07-21 15:11 ` Daniel P. Berrangé
2022-07-21 16:02 ` Zhao, Zhou
2022-07-21 16:28 ` Dr. David Alan Gilbert
2022-07-21 16:41 ` Daniel P. Berrangé [this message]
2022-07-22 2:23 ` Zhao, Zhou
2022-07-22 8:29 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtmBzCuMnY2kHr4f@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jun.i.jin@intel.com \
--cc=ling1.xu@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhou.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).