From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Zhao, Zhou" <zhou.zhao@intel.com>
Cc: "Xu, Ling1" <ling1.xu@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"quintela@redhat.com" <quintela@redhat.com>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"Jin, Jun I" <jun.i.jin@intel.com>
Subject: Re: [PATCH 1/1] Add AVX512 support for xbzrle_encode_buffer function
Date: Fri, 22 Jul 2022 09:29:58 +0100 [thread overview]
Message-ID: <YtpgBiHPLKZfendO@redhat.com> (raw)
In-Reply-To: <DM6PR11MB2812DBD3B12D3D3768CB46A4F5909@DM6PR11MB2812.namprd11.prod.outlook.com>
On Fri, Jul 22, 2022 at 02:23:13AM +0000, Zhao, Zhou wrote:
> 1 we need gcc machined options to tirgger gcc enable SIMD
> instructions(https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html).
> Or it will trigger a compile error. This is the reason why we
> change the config file.
Take a look at util/bufferiszero.c - that uses '#pragma GCC target'
to selectively change the compule target of individual functions.
This is what is njeeded here, because most distros are going to
compile QEMU with a very old x86_64 baseline, never turn on avx512
for the whole QEMU build. It needs to be very selective to make
it usable for typical deployments.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2022-07-22 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 10:31 [PATCH 0/1] This patch provides AVX512 support for xbzrle_encode_buffer function ling xu
2022-07-21 10:31 ` [PATCH 1/1] Add " ling xu
2022-07-21 15:11 ` Daniel P. Berrangé
2022-07-21 16:02 ` Zhao, Zhou
2022-07-21 16:28 ` Dr. David Alan Gilbert
2022-07-21 16:41 ` Daniel P. Berrangé
2022-07-22 2:23 ` Zhao, Zhou
2022-07-22 8:29 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtpgBiHPLKZfendO@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jun.i.jin@intel.com \
--cc=ling1.xu@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhou.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).