From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27E9AC00140 for ; Fri, 5 Aug 2022 13:11:01 +0000 (UTC) Received: from localhost ([::1]:56154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJx6S-0002P9-95 for qemu-devel@archiver.kernel.org; Fri, 05 Aug 2022 09:11:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJx1V-0004Jd-4v for qemu-devel@nongnu.org; Fri, 05 Aug 2022 09:05:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:53424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJx1T-0006ko-53 for qemu-devel@nongnu.org; Fri, 05 Aug 2022 09:05:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659704750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1TCj5D1HsUfgxM8YvKyt5t1p9ygjDCA6NUoVK35J7A=; b=Tvylo/WbARZV3WqC1q5119nPpzDiQQSv4uPeJLkVD5M7ABZDhshlsW91D1+gQMydmprtGs kC7SpjuKwL2STXBwDTbHtomoQh1uUBZ6GOWnFmObrTBsUDZzoyjSlr2SnZR3id99TfkLmk Jh1X5ugN1tJ8cLR9WI6oHl4xGvDY6ao= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-111-AuqGhHAOPjagkMAjL4tLZA-1; Fri, 05 Aug 2022 09:05:45 -0400 X-MC-Unique: AuqGhHAOPjagkMAjL4tLZA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A403538041C2; Fri, 5 Aug 2022 13:05:44 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E56F5C28125; Fri, 5 Aug 2022 13:05:42 +0000 (UTC) Date: Fri, 5 Aug 2022 15:05:41 +0200 From: Kevin Wolf To: Emanuele Giuseppe Esposito Cc: qemu-block@nongnu.org, Hanna Reitz , Paolo Bonzini , John Snow , Vladimir Sementsov-Ogievskiy , Wen Congyang , Xie Changlong , Markus Armbruster , Stefan Hajnoczi , Fam Zheng , qemu-devel@nongnu.org Subject: Re: [PATCH v10 20/21] blockjob: remove unused functions Message-ID: References: <20220725073855.76049-1-eesposit@redhat.com> <20220725073855.76049-21-eesposit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220725073855.76049-21-eesposit@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 25.07.2022 um 09:38 hat Emanuele Giuseppe Esposito geschrieben: > These public functions are not used anywhere, thus can be dropped. > > Signed-off-by: Emanuele Giuseppe Esposito > Reviewed-by: Stefan Hajnoczi > @@ -113,6 +111,7 @@ BlockJob *block_job_next_locked(BlockJob *job); > * Get the block job identified by @id (which must not be %NULL). > * > * Returns the requested job, or %NULL if it doesn't exist. > + * Called with job lock *not* held. > */ > BlockJob *block_job_get(const char *id); Unrelated hunk. Whatever: Reviewed-by: Kevin Wolf