qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Jinhao Fan <fanjinhao21s@ict.ac.cn>,
	qemu-devel@nongnu.org, its@irrelevant.dk, kbusch@kernel.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Julia Suvorova <jusual@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	"open list:Linux io_uring" <qemu-block@nongnu.org>
Subject: Re: [PATCH] block/io_uring: add missing include file
Date: Wed, 27 Jul 2022 18:44:15 +0200	[thread overview]
Message-ID: <YuFrX31f836vaPVW@redhat.com> (raw)
In-Reply-To: <20220721070956.js5rqulrpjx4i5ab@sgarzare-redhat>

Am 21.07.2022 um 09:09 hat Stefano Garzarella geschrieben:
> On Thu, Jul 21, 2022 at 02:56:45PM +0800, Jinhao Fan wrote:
> > The commit "Use io_uring_register_ring_fd() to skip fd operations" uses
> > warn_report but did not include the header file "qemu/error-report.h".
> > This causes "error: implicit declaration of function ‘warn_report’".
> > Include this header file.
> > 
> 
> We could add:
> 
> Fixes: e2848bc574 ("Use io_uring_register_ring_fd() to skip fd operations")
> 
> > Signed-off-by: Jinhao Fan <fanjinhao21s@ict.ac.cn>
> > ---
> > block/io_uring.c | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/block/io_uring.c b/block/io_uring.c
> > index f8a19fd97f..a1760152e0 100644
> > --- a/block/io_uring.c
> > +++ b/block/io_uring.c
> > @@ -11,6 +11,7 @@
> > #include "qemu/osdep.h"
> > #include <liburing.h>
> > #include "block/aio.h"
> > +#include "qemu/error-report.h"
> > #include "qemu/queue.h"
> > #include "block/block.h"
> > #include "block/raw-aio.h"
> > -- 
> > 2.25.1
> > 
> > 
> 
> Thanks for the fix:
> 
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks, applied to the block branch.

Kevin



      reply	other threads:[~2022-07-27 17:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21  6:56 [PATCH] block/io_uring: add missing include file Jinhao Fan
2022-07-21  7:09 ` Stefano Garzarella
2022-07-27 16:44   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuFrX31f836vaPVW@redhat.com \
    --to=kwolf@redhat.com \
    --cc=fanjinhao21s@ict.ac.cn \
    --cc=hreitz@redhat.com \
    --cc=its@irrelevant.dk \
    --cc=jusual@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=mehta.aaru20@gmail.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).