From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5932DC04A68 for ; Thu, 28 Jul 2022 10:25:00 +0000 (UTC) Received: from localhost ([::1]:38114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oH0hO-0002q7-Vq for qemu-devel@archiver.kernel.org; Thu, 28 Jul 2022 06:24:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH0fh-0001g0-LZ for qemu-devel@nongnu.org; Thu, 28 Jul 2022 06:23:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57977) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH0fd-0003mb-Ka for qemu-devel@nongnu.org; Thu, 28 Jul 2022 06:23:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659003788; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A+7jehwJQUlTljn7foPGhRyYq9uPjkZEPlWsS4J8f3k=; b=dFF30jQHbFqYYF7ZId3cfmtIN1G1MnP/ejDyF9mwzPraj9QAQWDM+WWya7oYB2T/nFzMaf zwGmO5PlKw636mv71cPf46+BwV+Ln/+h3lA+SSKSPWsfPothn1smPlxrBpNkzlDC72eEhV bBruoy7VX2yxnvjEPgrLVqRhrC/TxlA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-o_fT_mKbOPaQsJfc5QCKqA-1; Thu, 28 Jul 2022 06:23:05 -0400 X-MC-Unique: o_fT_mKbOPaQsJfc5QCKqA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA8D43C01E15; Thu, 28 Jul 2022 10:23:04 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D6BE1121314; Thu, 28 Jul 2022 10:23:03 +0000 (UTC) Date: Thu, 28 Jul 2022 11:23:00 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: Igor Mammedov , qemu-devel@nongnu.org, mst@redhat.com, t0rr3sp3dr0@gmail.com, alex.bennee@linaro.org, dgilbert@redhat.com, agraf@suse.de Subject: Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used Message-ID: References: <20220728093558.1163751-1-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote: > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé wrote: > > > > On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote: > > > QEMU probably can't carry OSK key[1] for legal reasons so it > > > can't supply the valid default key. However when tests are run > > > applesmc will pollute test log with distracting warning, > > > silence that warning so it won't distract maintainers/CI. > > > > What test is causing this problem ? > > bios-tables-test -- see here for the relevant bit of the log: > > https://lore.kernel.org/qemu-devel/CAFEAcA8u8jm7b+JD_t0qMNMy+WSJPOw=qxqptZpwTp=TkcXrhg@mail.gmail.com/ The right fix is for bios-tables-tests to pass an explicit 'osk' value then. As its a test it doesn't have to be a genuine OSK, jsut any old 64-byte string diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 359916c228..f6b5adf200 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -1632,7 +1632,7 @@ static void test_acpi_q35_applesmc(void) .variant = ".applesmc", }; - test_acpi_one("-device isa-applesmc", &data); + test_acpi_one("-device isa-applesmc,osk=iamalsonottherealoskimjustheretostopbiostablestestspammingstderr", &data); free_test_data(&data); } With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|