* [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key
@ 2022-07-28 13:37 Igor Mammedov
2022-07-28 13:40 ` Daniel P. Berrangé
2022-08-09 11:40 ` Igor Mammedov
0 siblings, 2 replies; 4+ messages in thread
From: Igor Mammedov @ 2022-07-28 13:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, peter.maydell, ani, berrange
OSK value is irrelevant for ACPI test case.
Supply fake OSK explicitly to prevent QEMU complaining about
invalid key when it fallbacks to default_osk.
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 359916c228..7c5f736b51 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
.variant = ".applesmc",
};
- test_acpi_one("-device isa-applesmc", &data);
+ /* supply fake 64-byte OSK to silence missing key warning */
+ test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
+ "topreventinvalidkeywarningsonstderr", &data);
free_test_data(&data);
}
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key
2022-07-28 13:37 [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key Igor Mammedov
@ 2022-07-28 13:40 ` Daniel P. Berrangé
2022-08-09 11:40 ` Igor Mammedov
1 sibling, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2022-07-28 13:40 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, mst, peter.maydell, ani
On Thu, Jul 28, 2022 at 09:37:13AM -0400, Igor Mammedov wrote:
> OSK value is irrelevant for ACPI test case.
> Supply fake OSK explicitly to prevent QEMU complaining about
> invalid key when it fallbacks to default_osk.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 359916c228..7c5f736b51 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
> .variant = ".applesmc",
> };
>
> - test_acpi_one("-device isa-applesmc", &data);
> + /* supply fake 64-byte OSK to silence missing key warning */
> + test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
> + "topreventinvalidkeywarningsonstderr", &data);
> free_test_data(&data);
> }
All 64 chars present and correct.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key
2022-07-28 13:37 [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key Igor Mammedov
2022-07-28 13:40 ` Daniel P. Berrangé
@ 2022-08-09 11:40 ` Igor Mammedov
2022-08-09 11:42 ` Michael S. Tsirkin
1 sibling, 1 reply; 4+ messages in thread
From: Igor Mammedov @ 2022-08-09 11:40 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, peter.maydell, ani, berrange
On Thu, 28 Jul 2022 09:37:13 -0400
Igor Mammedov <imammedo@redhat.com> wrote:
> OSK value is irrelevant for ACPI test case.
> Supply fake OSK explicitly to prevent QEMU complaining about
> invalid key when it fallbacks to default_osk.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Michael,
can you pick it up?
> ---
> tests/qtest/bios-tables-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 359916c228..7c5f736b51 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
> .variant = ".applesmc",
> };
>
> - test_acpi_one("-device isa-applesmc", &data);
> + /* supply fake 64-byte OSK to silence missing key warning */
> + test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
> + "topreventinvalidkeywarningsonstderr", &data);
> free_test_data(&data);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key
2022-08-09 11:40 ` Igor Mammedov
@ 2022-08-09 11:42 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2022-08-09 11:42 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, peter.maydell, ani, berrange
On Tue, Aug 09, 2022 at 01:40:24PM +0200, Igor Mammedov wrote:
> On Thu, 28 Jul 2022 09:37:13 -0400
> Igor Mammedov <imammedo@redhat.com> wrote:
>
> > OSK value is irrelevant for ACPI test case.
> > Supply fake OSK explicitly to prevent QEMU complaining about
> > invalid key when it fallbacks to default_osk.
> >
> > Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>
> Michael,
> can you pick it up?
Yes! In the next pull. I was hoping the linux seed thing will
settle but apparently no luck ...
> > ---
> > tests/qtest/bios-tables-test.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > index 359916c228..7c5f736b51 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -1632,7 +1632,9 @@ static void test_acpi_q35_applesmc(void)
> > .variant = ".applesmc",
> > };
> >
> > - test_acpi_one("-device isa-applesmc", &data);
> > + /* supply fake 64-byte OSK to silence missing key warning */
> > + test_acpi_one("-device isa-applesmc,osk=any64characterfakeoskisenough"
> > + "topreventinvalidkeywarningsonstderr", &data);
> > free_test_data(&data);
> > }
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-09 11:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-28 13:37 [PATCH for-7.1] tests: acpi: silence applesmc warning about invalid key Igor Mammedov
2022-07-28 13:40 ` Daniel P. Berrangé
2022-08-09 11:40 ` Igor Mammedov
2022-08-09 11:42 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).