From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 632F6C19F2A for ; Thu, 4 Aug 2022 12:27:02 +0000 (UTC) Received: from localhost ([::1]:54326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJZwL-0001QI-CG for qemu-devel@archiver.kernel.org; Thu, 04 Aug 2022 08:27:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJZTQ-0002hw-AA for qemu-devel@nongnu.org; Thu, 04 Aug 2022 07:57:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:22480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJZTM-0004gF-W8 for qemu-devel@nongnu.org; Thu, 04 Aug 2022 07:57:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659614223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UUE/gf1aayZAcrffeM2DHGLIHDhrbT3Bq0p+Ko+vj1o=; b=UBGNAkUetX92Jk+ZO8bsnZEykGbpCpz6w0qx7bqcZfve9xuOgGUdlrKaKJhKyAzjrqVzwv rCQFLHeMit6J+banfXNEFCu5OQPjvrcQViuigWqtSWsEp409+J6b7CtQ8/682FWkDUxgFo A9UD1Ui9uzsyTW7san4CjqVF5Z7Ph7Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-495-1tCxmVlgNey9nnrbnqlZ7Q-1; Thu, 04 Aug 2022 07:57:02 -0400 X-MC-Unique: 1tCxmVlgNey9nnrbnqlZ7Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2A1FE18E524F; Thu, 4 Aug 2022 11:57:02 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E658492CA2; Thu, 4 Aug 2022 11:56:59 +0000 (UTC) Date: Thu, 4 Aug 2022 13:56:57 +0200 From: Kevin Wolf To: Emanuele Giuseppe Esposito Cc: qemu-block@nongnu.org, Hanna Reitz , Paolo Bonzini , John Snow , Vladimir Sementsov-Ogievskiy , Wen Congyang , Xie Changlong , Markus Armbruster , Stefan Hajnoczi , Fam Zheng , qemu-devel@nongnu.org Subject: Re: [PATCH v10 09/21] jobs: use job locks also in the unit tests Message-ID: References: <20220725073855.76049-1-eesposit@redhat.com> <20220725073855.76049-10-eesposit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220725073855.76049-10-eesposit@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 25.07.2022 um 09:38 hat Emanuele Giuseppe Esposito geschrieben: > Add missing job synchronization in the unit tests, with > explicit locks. > > We are deliberately using _locked functions wrapped by a guard > instead of a normal call because the normal call will be removed > in future, as the only usage is limited to the tests. > > In other words, if a function like job_pause() is/will be only used > in tests to avoid: > > WITH_JOB_LOCK_GUARD(){ > job_pause_locked(); > } > > then it is not worth keeping job_pause(), and just use the guard. > > Note: at this stage, job_{lock/unlock} and job lock guard macros > are *nop*. > > Signed-off-by: Emanuele Giuseppe Esposito > Reviewed-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf