From: Stefan Hajnoczi <stefanha@redhat.com>
To: Yusuke Okada <yokada.996@gmail.com>
Cc: qemu-devel@nongnu.org, Yusuke Okada <okada.yusuke@jp.fujitsu.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"open list:virtiofs" <virtio-fs@redhat.com>
Subject: Re: [PATCH] virtiofsd: use g_date_time_get_microsecond to get subsecond
Date: Wed, 24 Aug 2022 13:41:29 -0400 [thread overview]
Message-ID: <YwZiyXqPTlSadOOR@fedora> (raw)
In-Reply-To: <20220818184618.2205172-1-yokada.996@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On Thu, Aug 18, 2022 at 02:46:19PM -0400, Yusuke Okada wrote:
> From: Yusuke Okada <okada.yusuke@jp.fujitsu.com>
>
> The "%f" specifier in g_date_time_format() is only available in glib
> 2.65.2 or later. If combined with older glib, the function returns null
> and the timestamp displayed as "(null)".
>
> For backward compatibility, g_date_time_get_microsecond should be used
> to retrieve subsecond.
>
> In this patch the g_date_time_format() leaves subsecond field as "%06d"
> and let next snprintf to format with g_date_time_get_microsecond.
>
> Signed-off-by: Yusuke Okada <okada.yusuke@jp.fujitsu.com>
> ---
> tools/virtiofsd/passthrough_ll.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Thanks, applied to my block tree for QEMU 7.2:
https://gitlab.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-08-24 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 18:46 [PATCH] virtiofsd: use g_date_time_get_microsecond to get subsecond Yusuke Okada
2022-08-24 11:05 ` Dr. David Alan Gilbert
2022-08-24 17:41 ` Stefan Hajnoczi [this message]
2022-09-20 17:58 ` [Virtio-fs] " Vivek Goyal
2022-09-27 15:50 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2022-08-18 17:46 Yusuke Okada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwZiyXqPTlSadOOR@fedora \
--to=stefanha@redhat.com \
--cc=dgilbert@redhat.com \
--cc=okada.yusuke@jp.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-fs@redhat.com \
--cc=yokada.996@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).