* [PATCH] tests: mark io-command test as skipped if socat is missing
@ 2022-09-01 11:04 marcandre.lureau
2022-09-01 11:05 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: marcandre.lureau @ 2022-09-01 11:04 UTC (permalink / raw)
To: qemu-devel; +Cc: berrange, Marc-André Lureau
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
tests/unit/test-io-channel-command.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/unit/test-io-channel-command.c b/tests/unit/test-io-channel-command.c
index 99056e07c0..aa09c559cd 100644
--- a/tests/unit/test-io-channel-command.c
+++ b/tests/unit/test-io-channel-command.c
@@ -41,7 +41,8 @@ static void test_io_channel_command_fifo(bool async)
unlink(TEST_FIFO);
if (access("/bin/socat", X_OK) < 0) {
- return; /* Pretend success if socat is not present */
+ g_test_skip("socat is missing");
+ return;
}
if (mkfifo(TEST_FIFO, 0600) < 0) {
abort();
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests: mark io-command test as skipped if socat is missing
2022-09-01 11:04 [PATCH] tests: mark io-command test as skipped if socat is missing marcandre.lureau
@ 2022-09-01 11:05 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2022-09-01 11:05 UTC (permalink / raw)
To: marcandre.lureau; +Cc: qemu-devel
On Thu, Sep 01, 2022 at 03:04:14PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/unit/test-io-channel-command.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/unit/test-io-channel-command.c b/tests/unit/test-io-channel-command.c
> index 99056e07c0..aa09c559cd 100644
> --- a/tests/unit/test-io-channel-command.c
> +++ b/tests/unit/test-io-channel-command.c
> @@ -41,7 +41,8 @@ static void test_io_channel_command_fifo(bool async)
>
> unlink(TEST_FIFO);
> if (access("/bin/socat", X_OK) < 0) {
> - return; /* Pretend success if socat is not present */
> + g_test_skip("socat is missing");
> + return;
> }
> if (mkfifo(TEST_FIFO, 0600) < 0) {
> abort();
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-01 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-01 11:04 [PATCH] tests: mark io-command test as skipped if socat is missing marcandre.lureau
2022-09-01 11:05 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).