From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, robh+dt@kernel.org,
eauger@redhat.com
Subject: Re: [PATCH 08/10] hw/arm/virt: Fix devicetree warnings about the GPIO node
Date: Thu, 1 Sep 2022 15:59:55 +0100 [thread overview]
Message-ID: <YxDI67Pwc6AMNKXm@myrica> (raw)
In-Reply-To: <CAFEAcA-8wCHuj6tZN0VB1boaOy50TtwpyUMziFgk2G4++Ay16A@mail.gmail.com>
On Wed, Aug 24, 2022 at 08:48:26PM +0100, Peter Maydell wrote:
> On Wed, 24 Aug 2022 at 16:51, Jean-Philippe Brucker
> <jean-philippe@linaro.org> wrote:
> >
> > The GPIO devicetree node is missing "interrupt-controller" and
> > "#interrupt-cells" properties:
> >
> > pl061@9030000: 'interrupt-controller' is a required property
> > From schema: linux/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml
> > pl061@9030000: '#interrupt-cells' is a required property
> > From schema: linux/Documentation/devicetree/bindings/gpio/pl061-gpio.yaml
>
> Why? This is a GPIO controller, not an interrupt controller.
> It seems wrong to be advertising in the dtb that it is.
pl061 can be used as an interrupt controller, and I think it's wired that
way, with GPIO key acting as an interrupt source. I'll add this to the
commit message.
Thanks,
Jean
next prev parent reply other threads:[~2022-09-01 15:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 15:51 [PATCH 00/10] hw/arm/virt: Fix dt-schema warnings Jean-Philippe Brucker
2022-08-24 15:51 ` [PATCH 01/10] hw/arm/virt: Fix devicetree warning about the root node Jean-Philippe Brucker
2022-08-24 15:51 ` [PATCH 02/10] hw/arm/boot: Fix devicetree warning about the PSCI node Jean-Philippe Brucker
2022-08-24 19:33 ` Peter Maydell
2022-09-01 14:53 ` Jean-Philippe Brucker
2022-08-24 15:51 ` [PATCH 03/10] hw/arm/virt: Fix devicetree warnings about the GIC node Jean-Philippe Brucker
2022-08-24 19:36 ` Peter Maydell
2022-09-01 14:55 ` Jean-Philippe Brucker
2022-08-24 15:51 ` [PATCH 04/10] hw/arm/virt: Use "msi-map" devicetree property for PCI Jean-Philippe Brucker
2022-08-24 15:51 ` [PATCH 05/10] hw/arm/virt: Fix devicetree warning about the timer node Jean-Philippe Brucker
2022-08-24 19:40 ` Peter Maydell
2022-09-01 14:58 ` Jean-Philippe Brucker
2022-08-24 15:51 ` [PATCH 06/10] hw/arm/virt: Fix devicetree warning about the gpio-key node Jean-Philippe Brucker
2022-08-24 15:51 ` [PATCH 07/10] hw/arm/virt: Fix devicetree warnings about node names Jean-Philippe Brucker
2022-08-24 15:51 ` [PATCH 08/10] hw/arm/virt: Fix devicetree warnings about the GPIO node Jean-Philippe Brucker
2022-08-24 19:48 ` Peter Maydell
2022-09-01 14:59 ` Jean-Philippe Brucker [this message]
2022-08-24 15:51 ` [PATCH 09/10] hw/arm/virt: Fix devicetree warnings about the SMMU node Jean-Philippe Brucker
2022-08-24 19:45 ` Peter Maydell
2022-09-01 15:01 ` Jean-Philippe Brucker
2022-08-24 15:51 ` [PATCH 10/10] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node Jean-Philippe Brucker
2022-08-24 19:51 ` Peter Maydell
2022-09-01 15:04 ` Jean-Philippe Brucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxDI67Pwc6AMNKXm@myrica \
--to=jean-philippe@linaro.org \
--cc=eauger@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).