From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: liuhaiwei9699 <liuhaiwei9699@126.com>,
qemu-devel@nongnu.org, pbonzini@redhat.com, eduardo@habkost.net,
eblake@redhat.com, liuhaiwei <liuhaiwei@inspur.com>
Subject: Re: [PATCH] Use QMP command object-add instead of object_add for memory hotplugin
Date: Thu, 8 Sep 2022 13:55:49 +0100 [thread overview]
Message-ID: <YxnmVZma5mPQwbyM@work-vm> (raw)
In-Reply-To: <87r10m59jj.fsf@pond.sub.org>
* Markus Armbruster (armbru@redhat.com) wrote:
> liuhaiwei9699 <liuhaiwei9699@126.com> writes:
>
> > why the hmp using the object_add , qmp using the object-add command?
> > can't we use the same command ?
>
> Command names differ between HMP and QMP for historical reasons.
>
> QMP is a stable interface, and changing names there is no go.
>
> HMP is not a stable interface, but changing names would still
> inconvenience users. We don't do that without really compelling
> reasons.
>
> I think HMP could fold '_' and '-' together in command names, so that
> both object_add and object-add work. Best to check with the HMP
> maintainer before you start coding.
Yes, I'd be up for having folding on _/- - I never remember which I need
in any case.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2022-09-08 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 9:52 [PATCH] Use QMP command object-add instead of object_add for memory hotplugin liuhaiwei
2022-09-08 11:41 ` Markus Armbruster
2022-09-08 11:52 ` liuhaiwei9699
2022-09-08 12:34 ` Markus Armbruster
2022-09-08 12:55 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxnmVZma5mPQwbyM@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=liuhaiwei9699@126.com \
--cc=liuhaiwei@inspur.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).