From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Claudio Fontana <cfontana@suse.de>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Akihiko Odaki" <akihiko.odaki@gmail.com>,
"Volker Rümelin" <vr_qemu@t-online.de>,
qemu-devel <qemu-devel@nongnu.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"BALATON Zoltan" <balaton@eik.bme.hu>
Subject: Re: [PATCH v3] audio: add help option for -audio and -audiodev
Date: Fri, 9 Sep 2022 14:50:09 +0100 [thread overview]
Message-ID: <YxtEkdBkYgiwMJyB@redhat.com> (raw)
In-Reply-To: <490c7ed8-53be-31de-1065-14b2fec492b2@suse.de>
On Fri, Sep 09, 2022 at 03:41:22PM +0200, Claudio Fontana wrote:
> On 9/9/22 00:05, Paolo Bonzini wrote:
> > Il gio 8 set 2022, 15:47 Claudio Fontana <cfontana@suse.de> ha scritto:
> >
> >> On 9/8/22 11:39, Paolo Bonzini wrote:
> >>> Queued, thanks.
> >>>
> >>> Paolo
> >>>
> >>>
> >>
> >> Thanks. When it comes to programmatic checks about what QEMU supports in
> >> terms of audio,
> >>
> >> is there something that can be done with QMP?
> >>
> >> I checked the QMP manual at:
> >>
> >>
> >> https://qemu.readthedocs.io/en/latest/interop/qemu-qmp-ref.html#qapidoc-2948
> >>
> >> but in the "Audio" section there is a bunch of Objects and enums defined,
> >> but no command to query them...
> >>
> > No, there's nothing yet.
You're now reminding me of the patch I sent a while ago for reporting
audiodev backends and then completely forgot to followup on
https://mail.gnu.org/archive/html/qemu-devel/2021-03/msg00656.html
> Interesting. What about Display (ie ui-*) ? I mean how do I figure out from, say, libvirt,
> everything that QEMU can do in terms of display, which drivers are actually installed?
>
> Same for block...
>
> with the increasing modularization of QEMU we should I presume strengthen the discoverability of QEMU capabilities right?
> This way we can configure once, and install just what is needed to match the user requirements, or distro variant.
>
> As Markus mentioned maybe a more general solution would be to have these things as qom objects so that a
>
> qom-list-types
> can be used to get all 'audiodev' types, or all 'display' types, or all 'block' types and solve the problem this way?
> Is there a more general problem / solution that I am not seeing?
In an idealized world (where we can ignore the reality of our
existing legacy codebase) I think all backends would simply
be QOM objects, and created with -object, avoiding the need for
any backend type specific CLI args like -audiodev / -netdev / etc.
This would actually also extend to frontends, devices, cpus,
machine types etc all being objects, ought to be creatable via
-object, not requiring -device, -machine.
If we lived in the world where everything was a QOM Object,
then qom-list-types would serve as the universal detection
mechanism for everything.
Back in our current reality of pre-existing legacy code though,
we have to be a little more pragmattic. If we can make things
into QOM objects that work with -object / qom-list-types that's
great, but if it is too much work we'll just have to create other
QMP commands for querying, such as the query-audiodev patch.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-09-09 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 8:14 [PATCH v3] audio: add help option for -audio and -audiodev Claudio Fontana
2022-09-08 9:39 ` Paolo Bonzini
2022-09-08 13:47 ` Claudio Fontana
2022-09-08 22:05 ` Paolo Bonzini
2022-09-09 4:20 ` Markus Armbruster
2022-09-09 13:41 ` Claudio Fontana
2022-09-09 13:50 ` Daniel P. Berrangé [this message]
2022-09-09 14:27 ` Claudio Fontana
2022-09-09 14:45 ` Daniel P. Berrangé
2022-09-16 10:43 ` Markus Armbruster
2022-09-16 10:50 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxtEkdBkYgiwMJyB@redhat.com \
--to=berrange@redhat.com \
--cc=akihiko.odaki@gmail.com \
--cc=armbru@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=cfontana@suse.de \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=richard.henderson@linaro.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).