From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4447DC54EE9 for ; Fri, 16 Sep 2022 09:27:56 +0000 (UTC) Received: from localhost ([::1]:44622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ7da-00054Y-Sa for qemu-devel@archiver.kernel.org; Fri, 16 Sep 2022 05:27:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ7QD-0003E8-0A for qemu-devel@nongnu.org; Fri, 16 Sep 2022 05:14:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:21914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ7Q5-00049E-MB for qemu-devel@nongnu.org; Fri, 16 Sep 2022 05:14:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663319636; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IgntpDde8Ub4Iy7q0p1DupaKkV1z8Q3biLtvYNXamco=; b=XJ4QOotX5X4v4ccu+DBl9j2W5m/k3qmiiA52LR1rXZlbO0rUTyq2Unqa03T3EIc6AYz5UV MvTduxKhj4tiG0pmVSXM4Y6X0jmJ1RPJhe0hR12+q74Xyagg6waxU3wMkBatUe8IEfnJnx VlN3mIA3+EFVf1014Udw0cIQld4XhxY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-203-Fo25-GwMNXOlMKPz4OE24Q-1; Fri, 16 Sep 2022 05:13:55 -0400 X-MC-Unique: Fo25-GwMNXOlMKPz4OE24Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFC81800B30; Fri, 16 Sep 2022 09:13:54 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A60E6492CA2; Fri, 16 Sep 2022 09:13:53 +0000 (UTC) Date: Fri, 16 Sep 2022 10:13:50 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, michael.roth@amd.com, jsnow@redhat.com, eblake@redhat.com, Gerd Hoffmann Subject: Re: [PATCH 07/27] qapi audio: Elide redundant has_FOO in generated C Message-ID: References: <20220915204317.3766007-1-armbru@redhat.com> <20220915204317.3766007-8-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220915204317.3766007-8-armbru@redhat.com> User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 15, 2022 at 10:42:57PM +0200, Markus Armbruster wrote: > The has_FOO for pointer-valued FOO are redundant, except for arrays. > They are also a nuisance to work with. Recent commit "qapi: Start to > elide redundant has_FOO in generated C" provided the means to elide > them step by step. This is the step for qapi/audio.json. > > Said commit explains the transformation in more detail. The invariant > violations mentioned there do not occur here. > > Additionally, helper get_str() loses its @has_dst parameter. > > Cc: Gerd Hoffmann > Signed-off-by: Markus Armbruster > --- > audio/alsaaudio.c | 2 +- > audio/audio.c | 6 ++---- > audio/audio_legacy.c | 17 +++++++---------- > audio/ossaudio.c | 8 +++----- > audio/paaudio.c | 12 ++++++------ > audio/wavaudio.c | 2 +- > scripts/qapi/schema.py | 1 - > 7 files changed, 20 insertions(+), 28 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|