From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D46CECAAD8 for ; Fri, 16 Sep 2022 08:41:34 +0000 (UTC) Received: from localhost ([::1]:56580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ6ui-0006o0-S5 for qemu-devel@archiver.kernel.org; Fri, 16 Sep 2022 04:41:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ6rP-0004K7-A7 for qemu-devel@nongnu.org; Fri, 16 Sep 2022 04:38:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ6rK-0003AZ-L1 for qemu-devel@nongnu.org; Fri, 16 Sep 2022 04:38:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663317481; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=ccq3PeLM/h656oZcdpDkoyw/c/vHztkPWJEmxQyBcSE=; b=gcMlXQFxxRkbGYZsGUdxbpLiznMqLtXhq9YVoy70+T2XFGY87PRXWyrpa00DsBYRmMv6jQ +dKHscnz+y+QJ8Y3HkgBTMIqEVhOoSWMZ2K1bDR8lheGqilRQpIhKm+PPHE9lDgsAnmfgO MUbvS9CatdFdPRYawD3/U04jJKA1RVs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-290-Y1079j3lOkCKSxSnUOJxzw-1; Fri, 16 Sep 2022 04:37:59 -0400 X-MC-Unique: Y1079j3lOkCKSxSnUOJxzw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 565978001B8; Fri, 16 Sep 2022 08:37:59 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EACDAC15BA4; Fri, 16 Sep 2022 08:37:57 +0000 (UTC) Date: Fri, 16 Sep 2022 09:37:55 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Ani Sinha Cc: Markus Armbruster , qemu-devel@nongnu.org, michael.roth@amd.com, jsnow@redhat.com, eblake@redhat.com, "Michael S . Tsirkin" , Igor Mammedov Subject: Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C Message-ID: References: <20220915204317.3766007-1-armbru@redhat.com> <20220915204317.3766007-7-armbru@redhat.com> <87illnenpv.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote: > On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster wrote: > > > > Ani Sinha writes: > > > > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster wrote: > > >> > > >> The has_FOO for pointer-valued FOO are redundant, except for arrays. > > >> They are also a nuisance to work with. Recent commit "qapi: Start to > > >> elide redundant has_FOO in generated C" > > > > > > Commit is referenced using ("commit header") > > > > Apply my patches in your tree, and your hashes will differ from mine. > > Hashes can serve as stable reference only when we git-fetch patches, not > > when we git-send-email then. > > Has the referenced patch not been pushed upstream already? I thought > it was and hence was asking for the reference. Err, it is just a few patches earlier in this very series you're looking at. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|