From: Kevin Wolf <kwolf@redhat.com>
To: songlinfeng <slf553@126.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] try to find out which cluster allocated in qcow2
Date: Thu, 22 Sep 2022 17:12:11 +0200 [thread overview]
Message-ID: <Yyx7S2DzzDrmY0ky@redhat.com> (raw)
In-Reply-To: <1663747050-122900-1-git-send-email-slf553@126.com>
Am 21.09.2022 um 09:57 hat songlinfeng geschrieben:
> In our project,we want to full backup a disk only allocated area,but
> qmp block-dity-block-add can create a bitmap with all zero,so we can't
> find out which cluster is allocated.in qcow2,I think l2_table can help
> me find out which cluster should be backup.
>
> Signed-off-by: songlinfeng <slf553@126.com>
You're just adding a new function without any callers. This would be
dead code. We don't generally commit dead code except as part of a
series where a later patch makes use of it.
Either way, since you just seem to print allocation status to stdout,
maybe 'qemu-img map' is actually the right tool for what you are
trying to do?
Kevin
prev parent reply other threads:[~2022-09-22 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 7:57 [PATCH] try to find out which cluster allocated in qcow2 songlinfeng
2022-09-22 15:12 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyx7S2DzzDrmY0ky@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slf553@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).