From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B894C54EE9 for ; Thu, 22 Sep 2022 17:28:13 +0000 (UTC) Received: from localhost ([::1]:34908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obPzg-00043i-Hy for qemu-devel@archiver.kernel.org; Thu, 22 Sep 2022 13:28:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obOWG-0006aJ-J6 for qemu-devel@nongnu.org; Thu, 22 Sep 2022 11:53:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:57352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obOWA-0003vZ-0H for qemu-devel@nongnu.org; Thu, 22 Sep 2022 11:53:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663862016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h8ggVpunGUgCjUjNkYByqIBl9YzO7ZvDcaqundoe6PQ=; b=dNj7ctKnvQCGsiatEURsxAmwpwC1jzCkMnl00iDGXEBpVO1qRBRcWapyYLlWe3juJAq5+o DZS8MDyS2iSRIIrMX1nKzZKFBj65KXdHHtanlDXKpCBCL71RM0tJXdsXapNaOgisZNHQeW E6OoRUl7f+ISUFxQFH+pj82wzide7UI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-103-8aj10-BMMJiZgvDl7wu5Gw-1; Thu, 22 Sep 2022 11:53:32 -0400 X-MC-Unique: 8aj10-BMMJiZgvDl7wu5Gw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C66CE1C0512D; Thu, 22 Sep 2022 15:53:31 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 75F4340C6E16; Thu, 22 Sep 2022 15:53:30 +0000 (UTC) Date: Thu, 22 Sep 2022 17:53:29 +0200 From: Kevin Wolf To: "Denis V. Lunev" Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Peter Krempa , Markus Armbruster , John Snow , Hanna Reitz , Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v5 0/2] block: add missed block_acct_setup with new block device init procedure Message-ID: References: <20220824095044.166009-1-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220824095044.166009-1-den@openvz.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 24.08.2022 um 11:50 hat Denis V. Lunev geschrieben: > Commit 5f76a7aac156ca75680dad5df4a385fd0b58f6b1 is looking harmless from > the first glance, but it has changed things a lot. 'libvirt' uses it to > detect that it should follow new initialization way and this changes > things considerably. With this procedure followed, blockdev_init() is > not called anymore and thus block_acct_setup() helper is not called. > > This means in particular that defaults for block accounting statistics > are changed and account_invalid/account_failed are actually initialized > as false instead of true originally. > > This commit changes things to match original world. There are the following > constraints: > * new default value in block_acct_init() is set to true > * block_acct_setup() inside blockdev_init() is called before > blkconf_apply_backend_options() > * thus newly created option in block device properties has precedence if > specified Thanks, applied to the block branch. Kevin