* [PULL 0/2] Hexagon target update
@ 2022-09-19 20:11 Taylor Simpson
2022-09-19 20:11 ` [PULL 1/2] Hexagon (target/hexagon) remove unused encodings Taylor Simpson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Taylor Simpson @ 2022-09-19 20:11 UTC (permalink / raw)
To: qemu-devel
Cc: tsimpson, richard.henderson, f4bug, peter.maydell, bcain,
quic_mathbern
The following changes since commit d29201ff34a135cdfc197f4413c1c5047e4f58bb:
Merge tag 'pull-hmp-20220915a' of https://gitlab.com/dagrh/qemu into staging (2022-09-17 10:31:11 -0400)
are available in the Git repository at:
https://github.com/quic/qemu tags/pull-hex-20220919
for you to fetch changes up to 8888ee42af726b9aba8245022fd4b7350a12acd3:
Hexagon (tests/tcg/hexagon): add fmin/fmax tests for signed zero (2022-09-19 11:55:23 -0700)
----------------------------------------------------------------
Hexagon target update
remove unused encodings
add fmin/fmax tests for signed zero
----------------------------------------------------------------
Matheus Tavares Bernardino (1):
Hexagon (tests/tcg/hexagon): add fmin/fmax tests for signed zero
Taylor Simpson (1):
Hexagon (target/hexagon) remove unused encodings
tests/tcg/hexagon/usr.c | 10 ++++++++++
target/hexagon/imported/encode_pp.def | 23 -----------------------
2 files changed, 10 insertions(+), 23 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PULL 1/2] Hexagon (target/hexagon) remove unused encodings
2022-09-19 20:11 [PULL 0/2] Hexagon target update Taylor Simpson
@ 2022-09-19 20:11 ` Taylor Simpson
2022-09-19 20:11 ` [PULL 2/2] Hexagon (tests/tcg/hexagon): add fmin/fmax tests for signed zero Taylor Simpson
2022-09-22 19:07 ` [PULL 0/2] Hexagon target update Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Taylor Simpson @ 2022-09-19 20:11 UTC (permalink / raw)
To: qemu-devel
Cc: tsimpson, richard.henderson, f4bug, peter.maydell, bcain,
quic_mathbern
Remove encodings guarded by ifdef that is not defined
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220606222327.7682-4-tsimpson@quicinc.com>
---
target/hexagon/imported/encode_pp.def | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/target/hexagon/imported/encode_pp.def b/target/hexagon/imported/encode_pp.def
index 939c6fc55f..d71c04cd30 100644
--- a/target/hexagon/imported/encode_pp.def
+++ b/target/hexagon/imported/encode_pp.def
@@ -944,13 +944,6 @@ MPY_ENC(F2_dfmpyfix, "1000","ddddd","0","0","1","0","11")
MPY_ENC(F2_dfmin, "1000","ddddd","0","0","1","1","11")
MPY_ENC(F2_dfmax, "1000","ddddd","0","1","0","0","11")
MPY_ENC(F2_dfmpyll, "1000","ddddd","0","1","0","1","11")
-#ifdef ADD_DP_OPS
-MPY_ENC(F2_dfdivcheat, "1000","ddddd","0","0","0","1","00")
-
-MPY_ENC(F2_dffixupn, "1000","ddddd","0","1","0","1","11")
-MPY_ENC(F2_dffixupd, "1000","ddddd","0","1","1","0","11")
-MPY_ENC(F2_dfrecipa, "1000","ddddd","0","1","1","1","ee")
-#endif
MPY_ENC(M7_dcmpyrw, "1000","ddddd","0","0","0","1","10")
MPY_ENC(M7_dcmpyrwc, "1000","ddddd","0","0","1","1","10")
@@ -1024,15 +1017,6 @@ MPY_ENC(M5_vdmacbsu, "1010","xxxxx","0","1","0","0","01")
MPY_ENC(F2_dfmpylh, "1010","xxxxx","0","0","0","0","11")
MPY_ENC(F2_dfmpyhh, "1010","xxxxx","0","0","0","1","11")
-#ifdef ADD_DP_OPS
-MPY_ENC(F2_dfmpyhh, "1010","xxxxx","0","0","1","0","11")
-MPY_ENC(F2_dffma, "1010","xxxxx","0","0","0","0","11")
-MPY_ENC(F2_dffms, "1010","xxxxx","0","0","0","1","11")
-
-MPY_ENC(F2_dffma_lib, "1010","xxxxx","0","0","1","0","11")
-MPY_ENC(F2_dffms_lib, "1010","xxxxx","0","0","1","1","11")
-MPY_ENC(F2_dffma_sc, "1010","xxxxx","0","1","1","1","uu")
-#endif
MPY_ENC(M7_dcmpyrw_acc, "1010","xxxxx","0","0","0","1","10")
@@ -1547,15 +1531,8 @@ SH2_RR_ENC(F2_conv_df2d, "0000","111","0","0 00","ddddd")
SH2_RR_ENC(F2_conv_df2ud, "0000","111","0","0 01","ddddd")
SH2_RR_ENC(F2_conv_ud2df, "0000","111","0","0 10","ddddd")
SH2_RR_ENC(F2_conv_d2df, "0000","111","0","0 11","ddddd")
-#ifdef ADD_DP_OPS
-SH2_RR_ENC(F2_dffixupr, "0000","111","0","1 00","ddddd")
-SH2_RR_ENC(F2_dfsqrtcheat, "0000","111","0","1 01","ddddd")
-#endif
SH2_RR_ENC(F2_conv_df2d_chop, "0000","111","0","1 10","ddddd")
SH2_RR_ENC(F2_conv_df2ud_chop,"0000","111","0","1 11","ddddd")
-#ifdef ADD_DP_OPS
-SH2_RR_ENC(F2_dfinvsqrta, "0000","111","1","0 ee","ddddd")
-#endif
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PULL 2/2] Hexagon (tests/tcg/hexagon): add fmin/fmax tests for signed zero
2022-09-19 20:11 [PULL 0/2] Hexagon target update Taylor Simpson
2022-09-19 20:11 ` [PULL 1/2] Hexagon (target/hexagon) remove unused encodings Taylor Simpson
@ 2022-09-19 20:11 ` Taylor Simpson
2022-09-22 19:07 ` [PULL 0/2] Hexagon target update Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Taylor Simpson @ 2022-09-19 20:11 UTC (permalink / raw)
To: qemu-devel
Cc: tsimpson, richard.henderson, f4bug, peter.maydell, bcain,
quic_mathbern
From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Tested-by: Taylor Simpson <tsimpson@quicinc.com>
---
tests/tcg/hexagon/usr.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tests/tcg/hexagon/usr.c b/tests/tcg/hexagon/usr.c
index a531511cec..fb4514989c 100644
--- a/tests/tcg/hexagon/usr.c
+++ b/tests/tcg/hexagon/usr.c
@@ -86,6 +86,7 @@ const uint32_t SF_QNaN_neg = 0xffc00000;
const uint32_t SF_SNaN_neg = 0xffb00000;
const uint32_t SF_HEX_NaN = 0xffffffff;
const uint32_t SF_zero = 0x00000000;
+const uint32_t SF_zero_neg = 0x80000000;
const uint32_t SF_one = 0x3f800000;
const uint32_t SF_one_recip = 0x3f7f0001; /* 0.9960... */
const uint32_t SF_one_invsqrta = 0x3f7f0000; /* 0.99609375 */
@@ -100,6 +101,7 @@ const uint64_t DF_QNaN_neg = 0xfff8000000000000ULL;
const uint64_t DF_SNaN_neg = 0xfff7000000000000ULL;
const uint64_t DF_HEX_NaN = 0xffffffffffffffffULL;
const uint64_t DF_zero = 0x0000000000000000ULL;
+const uint64_t DF_zero_neg = 0x8000000000000000ULL;
const uint64_t DF_any = 0x3f80000000000000ULL;
const uint64_t DF_one = 0x3ff0000000000000ULL;
const uint64_t DF_one_hh = 0x3ff001ff80000000ULL; /* 1.00048... */
@@ -933,6 +935,8 @@ int main()
TEST_R_OP_RR(sfmin, SF_QNaN, SF_one, SF_one, USR_CLEAR);
TEST_R_OP_RR(sfmin, SF_SNaN, SF_QNaN, SF_HEX_NaN, USR_FPINVF);
TEST_R_OP_RR(sfmin, SF_QNaN, SF_SNaN, SF_HEX_NaN, USR_FPINVF);
+ TEST_R_OP_RR(sfmin, SF_zero, SF_zero_neg, SF_zero_neg, USR_CLEAR);
+ TEST_R_OP_RR(sfmin, SF_zero_neg, SF_zero, SF_zero_neg, USR_CLEAR);
TEST_R_OP_RR(sfmax, SF_one, SF_small_neg, SF_one, USR_CLEAR);
TEST_R_OP_RR(sfmax, SF_one, SF_SNaN, SF_one, USR_FPINVF);
@@ -941,6 +945,8 @@ int main()
TEST_R_OP_RR(sfmax, SF_QNaN, SF_one, SF_one, USR_CLEAR);
TEST_R_OP_RR(sfmax, SF_SNaN, SF_QNaN, SF_HEX_NaN, USR_FPINVF);
TEST_R_OP_RR(sfmax, SF_QNaN, SF_SNaN, SF_HEX_NaN, USR_FPINVF);
+ TEST_R_OP_RR(sfmax, SF_zero, SF_zero_neg, SF_zero, USR_CLEAR);
+ TEST_R_OP_RR(sfmax, SF_zero_neg, SF_zero, SF_zero, USR_CLEAR);
TEST_R_OP_RR(sfadd, SF_one, SF_QNaN, SF_HEX_NaN, USR_CLEAR);
TEST_R_OP_RR(sfadd, SF_one, SF_SNaN, SF_HEX_NaN, USR_FPINVF);
@@ -1003,6 +1009,8 @@ int main()
TEST_P_OP_PP(dfmin, DF_QNaN, DF_any, DF_any, USR_CLEAR);
TEST_P_OP_PP(dfmin, DF_SNaN, DF_QNaN, DF_HEX_NaN, USR_FPINVF);
TEST_P_OP_PP(dfmin, DF_QNaN, DF_SNaN, DF_HEX_NaN, USR_FPINVF);
+ TEST_P_OP_PP(dfmin, DF_zero, DF_zero_neg, DF_zero_neg, USR_CLEAR);
+ TEST_P_OP_PP(dfmin, DF_zero_neg, DF_zero, DF_zero_neg, USR_CLEAR);
TEST_P_OP_PP(dfmax, DF_any, DF_small_neg, DF_any, USR_CLEAR);
TEST_P_OP_PP(dfmax, DF_any, DF_SNaN, DF_any, USR_FPINVF);
@@ -1011,6 +1019,8 @@ int main()
TEST_P_OP_PP(dfmax, DF_QNaN, DF_any, DF_any, USR_CLEAR);
TEST_P_OP_PP(dfmax, DF_SNaN, DF_QNaN, DF_HEX_NaN, USR_FPINVF);
TEST_P_OP_PP(dfmax, DF_QNaN, DF_SNaN, DF_HEX_NaN, USR_FPINVF);
+ TEST_P_OP_PP(dfmax, DF_zero, DF_zero_neg, DF_zero, USR_CLEAR);
+ TEST_P_OP_PP(dfmax, DF_zero_neg, DF_zero, DF_zero, USR_CLEAR);
TEST_XP_OP_PP(dfmpyhh, DF_one, DF_one, DF_one, DF_one_hh, USR_CLEAR);
TEST_XP_OP_PP(dfmpyhh, DF_zero, DF_any, DF_QNaN, DF_HEX_NaN, USR_CLEAR);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PULL 0/2] Hexagon target update
2022-09-19 20:11 [PULL 0/2] Hexagon target update Taylor Simpson
2022-09-19 20:11 ` [PULL 1/2] Hexagon (target/hexagon) remove unused encodings Taylor Simpson
2022-09-19 20:11 ` [PULL 2/2] Hexagon (tests/tcg/hexagon): add fmin/fmax tests for signed zero Taylor Simpson
@ 2022-09-22 19:07 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2022-09-22 19:07 UTC (permalink / raw)
To: Taylor Simpson
Cc: qemu-devel, tsimpson, richard.henderson, f4bug, peter.maydell,
bcain, quic_mathbern
[-- Attachment #1: Type: text/plain, Size: 313 bytes --]
Applied, thanks.
This pull request did not show up in the patches tool
(https://github.com/stefanha/patches) that I use. If I miss a pull
request from you in the future, please feel free to ping me after 48
hours.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-22 19:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-19 20:11 [PULL 0/2] Hexagon target update Taylor Simpson
2022-09-19 20:11 ` [PULL 1/2] Hexagon (target/hexagon) remove unused encodings Taylor Simpson
2022-09-19 20:11 ` [PULL 2/2] Hexagon (tests/tcg/hexagon): add fmin/fmax tests for signed zero Taylor Simpson
2022-09-22 19:07 ` [PULL 0/2] Hexagon target update Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).